You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "shubhamvishu (via GitHub)" <gi...@apache.org> on 2023/02/28 07:56:00 UTC
[GitHub] [lucene] shubhamvishu opened a new pull request, #12171: Add APIs to get ordinal and category cache hit/miss count and hit rate in DirectoryTaxonomyReader
shubhamvishu opened a new pull request, #12171:
URL: https://github.com/apache/lucene/pull/12171
### Description
Added apis in `DirectoryTaxonomyReader` to get the `ordinalCache` and `categoryCache` hit/miss count and also cache hit rate and a unit test `testCacheHitAndMissCount` to check the behaviour.
<!--
If this is your first contribution to Lucene, please make sure you have reviewed the contribution guide.
https://github.com/apache/lucene/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gsmiller commented on pull request #12171: Add APIs to get ordinal and category cache hit/miss count and hit rate in DirectoryTaxonomyReader
Posted by "gsmiller (via GitHub)" <gi...@apache.org>.
gsmiller commented on PR #12171:
URL: https://github.com/apache/lucene/pull/12171#issuecomment-1463977181
Closing this out for now since I don't think we want to add these APIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gsmiller commented on pull request #12171: Add APIs to get ordinal and category cache hit/miss count and hit rate in DirectoryTaxonomyReader
Posted by "gsmiller (via GitHub)" <gi...@apache.org>.
gsmiller commented on PR #12171:
URL: https://github.com/apache/lucene/pull/12171#issuecomment-1448296961
Thanks for opening a PR and for the idea! I'm a bit concerned adding this as a public API though. I see the cache as a bit of an implementation detail that could change in the future, but putting a public API on it makes changing it a bit trickier. In fact, there's actually an open issue where some benchmarking indicated the cache might not be providing any benefits (looks like we need to follow up there to see if that's still true): #11106
So for now, I'm not convinced we should actually add these public APIs. As a next step, let's get to the bottom of how much benefit we're actually seeing from the caches and challenge if we still need all the complexity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gsmiller closed pull request #12171: Add APIs to get ordinal and category cache hit/miss count and hit rate in DirectoryTaxonomyReader
Posted by "gsmiller (via GitHub)" <gi...@apache.org>.
gsmiller closed pull request #12171: Add APIs to get ordinal and category cache hit/miss count and hit rate in DirectoryTaxonomyReader
URL: https://github.com/apache/lucene/pull/12171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] shubhamvishu commented on pull request #12171: Add APIs to get ordinal and category cache hit/miss count and hit rate in DirectoryTaxonomyReader
Posted by "shubhamvishu (via GitHub)" <gi...@apache.org>.
shubhamvishu commented on PR #12171:
URL: https://github.com/apache/lucene/pull/12171#issuecomment-1448352841
Thats a good point @gsmiller. Looks like we didn't achieve to an conclusion there. I'll run some benchmarks with/without these caches and see if they are still useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gsmiller commented on pull request #12171: Add APIs to get ordinal and category cache hit/miss count and hit rate in DirectoryTaxonomyReader
Posted by "gsmiller (via GitHub)" <gi...@apache.org>.
gsmiller commented on PR #12171:
URL: https://github.com/apache/lucene/pull/12171#issuecomment-1448520203
Thanks @shubhamvishu! Really curious to see what we learn there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gsmiller commented on pull request #12171: Add APIs to get ordinal and category cache hit/miss count and hit rate in DirectoryTaxonomyReader
Posted by "gsmiller (via GitHub)" <gi...@apache.org>.
gsmiller commented on PR #12171:
URL: https://github.com/apache/lucene/pull/12171#issuecomment-1463977754
Thanks again @shubhamvishu for raising the idea and looking into the effectiveness of the caches more generally!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org