You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "mmartell (GitHub)" <gi...@apache.org> on 2018/11/28 03:14:19 UTC
[GitHub] [geode-native] mmartell opened pull request #411:
Geode-6054: Build with VS2017 and new gtest
[ Full content available at: https://github.com/apache/geode-native/pull/411 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] mmartell commented on pull request #411:
Geode-6054: Build with VS2017 and new gtest
Posted by "mmartell (GitHub)" <gi...@apache.org>.
Done.
[ Full content available at: https://github.com/apache/geode-native/pull/411 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] pivotal-jbarrett commented on issue #411:
Geode-6054: Build with VS2017 and new gtest
Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
No. I would just get a PR open for the image so others can test this change. As is there’s is no guidance on how to build a viable VS 2017 environment.
[ Full content available at: https://github.com/apache/geode-native/pull/411 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] mmartell closed pull request #411:
Geode-6054: Build with VS2017 and new gtest
Posted by "mmartell (GitHub)" <gi...@apache.org>.
[ pull request closed by mmartell ]
[ Full content available at: https://github.com/apache/geode-native/pull/411 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] mmartell commented on issue #411: Geode-6054:
Build with VS2017 and new gtest
Posted by "mmartell (GitHub)" <gi...@apache.org>.
Agreed. Should I close this PR for now?
[ Full content available at: https://github.com/apache/geode-native/pull/411 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] mmartell commented on pull request #411:
Geode-6054: Build with VS2017 and new gtest
Posted by "mmartell (GitHub)" <gi...@apache.org>.
Done
[ Full content available at: https://github.com/apache/geode-native/pull/411 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] mmartell commented on issue #411: Geode-6054:
Build with VS2017 and new gtest
Posted by "mmartell (GitHub)" <gi...@apache.org>.
All requested changes completed.
[ Full content available at: https://github.com/apache/geode-native/pull/411 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] pivotal-jbarrett commented on issue #411:
Geode-6054: Build with VS2017 and new gtest
Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
No. I would just get a PR open for the image so others can test this change. As is there’s is no guidance on how to build a viable VS 2017 environment. After that PR is accepted then you could merge this one.
[ Full content available at: https://github.com/apache/geode-native/pull/411 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] pivotal-jbarrett commented on pull request
#411: Geode-6054: Build with VS2017 and new gtest
Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
Delete
[ Full content available at: https://github.com/apache/geode-native/pull/411 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] pivotal-jbarrett commented on pull request
#411: Geode-6054: Build with VS2017 and new gtest
Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
Delete
[ Full content available at: https://github.com/apache/geode-native/pull/411 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org