You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "clebertsuconic (via GitHub)" <gi...@apache.org> on 2024/12/05 21:08:25 UTC
[PR] ARTEMIS-4173 Improving reliability on RandomReattachTest [activemq-artemis]
clebertsuconic opened a new pull request, #5384:
URL: https://github.com/apache/activemq-artemis/pull/5384
- making the test to run faster and removing the soak and stress versions as they are not really needed
- allowing expected exceptions (cannot find ACK, and making it retry the operation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4173 Improving reliability on RandomReattachTest [activemq-artemis]
Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram merged PR #5384:
URL: https://github.com/apache/activemq-artemis/pull/5384
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4173 Improving reliability on RandomReattachTest [activemq-artemis]
Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram commented on PR #5384:
URL: https://github.com/apache/activemq-artemis/pull/5384#issuecomment-2521703165
It's hard to tell what semantic change you actually made. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4173 Improving reliability on RandomReattachTest [activemq-artemis]
Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic commented on PR #5384:
URL: https://github.com/apache/activemq-artemis/pull/5384#issuecomment-2521709440
@jbertram I removed the testBase and I made it a test.. I guess it makes difficult to see the diffs...
the main diff is this:
https://github.com/apache/activemq-artemis/blob/3d196ad70c0a9db145fae003877950fc4e144077/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/reattach/RandomReattachIntegrationTest.java#L228-L253
there's a check of expectedException.... if it's an expected exception it will just skip and increase the numIts.
I also closed the SessionFactory, and locators and stop the server since there was a leak between the tests.
We could go further and just ignore any exception to an individualACK however that's not really wise.. since not that many people really use reattachment, and if this happens users should still treat it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-4173 Improving reliability on RandomReattachTest [activemq-artemis]
Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic commented on PR #5384:
URL: https://github.com/apache/activemq-artemis/pull/5384#issuecomment-2521697711
I'm merging this as soon as my tests are done... tests are showing extremely good results..
if anyone has any issues with this merge, please let me know and we can review it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact