You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "Musxeto (via GitHub)" <gi...@apache.org> on 2026/08/30 13:13:46 UTC
[PR] fix(deps, frontend): deduplicate Angular toolchain under @angular-builders/custom-webpack [texera]
Musxeto opened a new pull request, #8127:
URL: https://github.com/apache/texera/pull/8127
**What changes were proposed in this PR?**
Adds three Yarn `resolutions` entries to `frontend/package.json` to force
`@angular-builders/custom-webpack`'s transitive dependencies to the same versions
already pinned in `devDependencies`:
- `@angular-devkit/build-angular` → `21.2.19`
- `@angular/build` → `21.2.19`
- `@ngtools/webpack` → `21.2.19`
`@angular-builders/custom-webpack@21.1.0` declares a loose dep on
`@angular-devkit/build-angular: ^21.0.0`, which Yarn was resolving to `21.2.18`.
This created a nested copy of the toolchain under the builder's own `node_modules/`
while the pinned `21.2.19` sat unused at the workspace root. Because `angular.json`
routes both `build` and `serve` through `@angular-builders/custom-webpack`, the
older toolchain (`21.2.18`) was the one actually compiling the app and running the
dev server — silently, with CI staying green. The same split affected `@angular/build`
and `@ngtools/webpack`.
The `resolutions` field was already in use in `frontend/package.json` for
`monaco-editor`, `webpack`, and `jschardet`; this PR follows the same pattern.
Result: 276 lines removed from `yarn.lock`; all three packages now have a single
lockfile entry at `21.2.19`; the nested
`@angular-builders/custom-webpack/node_modules/@angular-devkit/` copy is gone.
No production source code files were modified.
---
**Any related issues, documentation, discussions?**
Closes #8052
---
**How was this PR tested?**
Verified the lockfile and installed tree after running `yarn install` inside `frontend/`:
```bash
# 1. Single lockfile entry per package — no more split at 21.2.18:
grep -n '^"@angular-devkit/build-angular@\|^"@angular/build@\|^"@ngtools/webpack@' \
frontend/yarn.lock
# 298:"@angular-devkit/build-angular@npm:21.2.19":
# 571:"@angular/build@npm:21.2.19":
# 4294:"@ngtools/webpack@npm:21.2.19":
# 2. No nested @angular-devkit copy under the builder:
ls frontend/node_modules/@angular-builders/custom-webpack/node_modules/
# only `source-map` remains — no @angular-devkit
# 3. Installed version matches the pin:
node -e "console.log(require('./frontend/node_modules/@angular-devkit/build-angular/package.json').version)"
# 21.2.19
```
---
**Was this PR authored or co-authored using generative AI tooling?**
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(deps, frontend): deduplicate Angular toolchain under @angular-builders/custom-webpack [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8127:
URL: https://github.com/apache/texera/pull/8127#issuecomment-5468901398
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@renovate-bot`
You can notify them by mentioning `@renovate-bot` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(deps, frontend): deduplicate Angular toolchain under @angular-builders/custom-webpack [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #8127:
URL: https://github.com/apache/texera/pull/8127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(deps, frontend): deduplicate Angular toolchain under @angular-builders/custom-webpack [texera]
Posted by "Ma77Ball (via GitHub)" <gi...@apache.org>.
Ma77Ball commented on PR #8127:
URL: https://github.com/apache/texera/pull/8127#issuecomment-5706456552
@xuang7 and @aglinxinyuan, please fix the CI (rerun it on GitHub UI).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(deps, frontend): deduplicate Angular toolchain under @angular-builders/custom-webpack [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8127:
URL: https://github.com/apache/texera/pull/8127#issuecomment-5468900582
<!-- texera:template-compliance -->
👋 Thanks for opening this pull request, @Musxeto!
It looks like the pull request description doesn't quite follow our template yet:
- The **What changes were proposed in this PR?** section is missing; please keep the template's headings.
- The **How was this PR tested?** section is missing; please keep the template's headings.
- The **Was this PR authored or co-authored using generative AI tooling?** section is missing; please keep the template's headings.
Filling out the template helps reviewers understand and triage your contribution faster. Please edit the description to complete it. This message will disappear automatically once the template is followed.
You can find the template prompts by editing the description, or see [CONTRIBUTING.md](https://github.com/apache/texera/blob/main/CONTRIBUTING.md) for the full contribution flow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(deps, frontend): deduplicate Angular toolchain under @angular-builders/custom-webpack [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8127:
URL: https://github.com/apache/texera/pull/8127#issuecomment-5468901280
<!-- backport-auto-label-report -->
### Backport auto-label report
This `fix:` PR was checked against each actively-supported release branch. `release/*` labels drive the post-merge backport, so add or remove one to change where this fix lands.
| Release branch | Analysis |
| --- | --- |
| ⚠️ `release/v1.3` | Not labeled automatically — none of the files this PR modifies exist on this branch (`frontend/package.json`, `frontend/yarn.lock`). The fix may target code that isn't on this release, or the files were moved/renamed after the branch was cut. **Please check and add `release/v1.3` by hand if this fix should be backported here.** |
| ✅ `release/v1.2` | Change detected on this branch — label added; this fix is queued to backport here. Requested review from @xuang7. |
_[Auto-label run](https://github.com/apache/texera/actions/runs/33313603162)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(deps, frontend): deduplicate Angular toolchain under @angular-builders/custom-webpack [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8127:
URL: https://github.com/apache/texera/pull/8127#issuecomment-5468942122
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/8127?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 94.03%. Comparing base ([`98588bf`](https://app.codecov.io/gh/apache/texera/commit/98588bf2ab49aac65ebf002496eb057670e6fc07?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4a38195`](https://app.codecov.io/gh/apache/texera/commit/4a38195f89c5e7583521be27fd94de229dc4f73a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #8127 +/- ##
=========================================
Coverage 94.03% 94.03%
Complexity 4762 4762
=========================================
Files 1181 1181
Lines 47877 47877
Branches 5324 5324
=========================================
Hits 45020 45020
Misses 1433 1433
Partials 1424 1424
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/8127/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/8127/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.00% <ø> (ø)` | | Carriedforward from [98588bf](https://app.codecov.io/gh/apache/texera/commit/98588bf2ab49aac65ebf002496eb057670e6fc07?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/8127/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `99.32% <ø> (ø)` | | Carriedforward from [98588bf](https://app.codecov.io/gh/apache/texera/commit/98588bf2ab49aac65ebf002496eb057670e6fc07?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/8127/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.03% <ø> (ø)` | | Carriedforward from [98588bf](https://app.codecov.io/gh/apache/texera/commit/98588bf2ab49aac65ebf002496eb057670e6fc07?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/8127/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.67% <ø> (ø)` | | Carriedforward from [98588bf](https://app.codecov.io/gh/apache/texera/commit/98588bf2ab49aac65ebf002496eb057670e6fc07?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/8127/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `86.86% <ø> (ø)` | | Carriedforward from [98588bf](https://app.codecov.io/gh/apache/texera/commit/98588bf2ab49aac65ebf002496eb057670e6fc07?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/8127/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.91% <ø> (ø)` | | Carriedforward from [98588bf](https://app.codecov.io/gh/apache/texera/commit/98588bf2ab49aac65ebf002496eb057670e6fc07?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/8127/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.68% <ø> (ø)` | | |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/8127/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `79.31% <ø> (ø)` | | Carriedforward from [98588bf](https://app.codecov.io/gh/apache/texera/commit/98588bf2ab49aac65ebf002496eb057670e6fc07?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/8127/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `98.87% <ø> (ø)` | | Carriedforward from [98588bf](https://app.codecov.io/gh/apache/texera/commit/98588bf2ab49aac65ebf002496eb057670e6fc07?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/8127/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.19% <ø> (ø)` | | Carriedforward from [98588bf](https://app.codecov.io/gh/apache/texera/commit/98588bf2ab49aac65ebf002496eb057670e6fc07?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/8127?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org