[GitHub] [dubbo-go] cjphaha commented on a change in pull request #1378: feat(getty): upgrade getty version to 1.4.5 for dubbo-go 1.5

[GitBox <gi...@apache.org>]

cjphaha commented on a change in pull request #1378:
URL: https://github.com/apache/dubbo-go/pull/1378#discussion_r690973686



##########
File path: remoting/getty/listener.go
##########
@@ -26,11 +26,14 @@ import (
 
 import (
 	"github.com/apache/dubbo-getty"
-	hessian "github.com/apache/dubbo-go-hessian2"
+
+	gxtime "github.com/dubbogo/gost/time"
+
 	perrors "github.com/pkg/errors"
 )
 
 import (
+	hessian "github.com/apache/dubbo-go-hessian2"

Review comment:
       这个 `hessian "github.com/apache/dubbo-go-hessian2"` 是不是应该放在第二个import块会更好一些，因为第三个import块都是`github.com/apache/dubbo-go/ `前缀




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org