[GitHub] [drill] vvysotskyi commented on a change in pull request #2055: DRILL-7693: Updated protobuf version to 3.11.1

[GitBox <gi...@apache.org>]

vvysotskyi commented on a change in pull request #2055: DRILL-7693: Updated protobuf version to 3.11.1
URL: https://github.com/apache/drill/pull/2055#discussion_r408057597
 
 

 ##########
 File path: common/src/main/java/org/apache/drill/common/util/ProtobufPatcher.java
 ##########
 @@ -57,15 +60,15 @@ public static synchronized void patch() {
   private static void patchByteString() {
     try {
       ClassPool classPool = getClassPool();
-      CtClass byteString = classPool.get("com.google.protobuf.ByteString");
+      CtClass byteString = classPool.get(protobufPackage + "ByteString");
 
 Review comment:
   I'm afraid it will break JDBC client. As you know, we shade protobuf jars into JDBC driver and relocate them from `com.google` to `oadd.com.google`.
   Shade plugin traverses all classes and replaces packages with updated ones. String literal with full class name also will be updated, but with your change, it breaks this behavior, so classes wouldn't be shades.
   See the description of this behavior here: https://issues.apache.org/jira/browse/MSHADE-156. 
   
   After fixing this issue, please ensure that the custom authenticator works correctly with your changes (this one should break it).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services