You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/01/09 00:34:01 UTC
[GitHub] [orc] williamhyun opened a new pull request #611: Add Java 17-ea
williamhyun opened a new pull request #611:
URL: https://github.com/apache/orc/pull/611
<!--
Thanks for sending a pull request! Here are some tips for you:
1. File a JIRA issue first and use it as a prefix of your PR title, e.g., `ORC-001: Fix ABC`.
2. Use your PR title to summarize what this PR proposes instead of describing the problem.
3. Make PR title and description complete because these will be the permanent commit log.
4. If possible, provide a concise and reproducible example to reproduce the issue for a faster review.
5. If the PR is unfinished, use GitHub PR Draft feature.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun edited a comment on pull request #611: ORC-713: Add Java 17-ea to GitHub action
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #611:
URL: https://github.com/apache/orc/pull/611#issuecomment-757092461
It seems that we need to upgrade the test dependency to enable Java 17-ea testing.
For my previous comment, I created ORC-717. Feel free to pick up it if you have some time.
> According to the log, `mockito` can be a root cause. Could you upgrade `mockito-core` first in a separate PR, please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] williamhyun commented on pull request #611: ORC-713: Add Java 17-ea to GitHub action
Posted by GitBox <gi...@apache.org>.
williamhyun commented on pull request #611:
URL: https://github.com/apache/orc/pull/611#issuecomment-757086056
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #611: ORC-713: Add Java 17-ea to GitHub action
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #611:
URL: https://github.com/apache/orc/pull/611#issuecomment-757088764
You may want to upgrade GitHub Action OS. Currently, it's `18.04` although we specify `ubuntu-latest`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] williamhyun commented on pull request #611: ORC-713: Add Java 17-ea to GitHub action
Posted by GitBox <gi...@apache.org>.
williamhyun commented on pull request #611:
URL: https://github.com/apache/orc/pull/611#issuecomment-761684252
Sure, @dongjoon-hyun I'll try with Java 15.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #611: ORC-713: Add Java 17-ea to GitHub action
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #611:
URL: https://github.com/apache/orc/pull/611#issuecomment-757089400
Thank you for updating, @williamhyun !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] williamhyun commented on pull request #611: ORC-713: Add Java 17-ea to GitHub action
Posted by GitBox <gi...@apache.org>.
williamhyun commented on pull request #611:
URL: https://github.com/apache/orc/pull/611#issuecomment-757375927
Oops, I created ORC-723 for that. Please see [this](https://github.com/apache/orc/pull/617).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #611: ORC-713: Add Java 17-ea to GitHub action
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #611:
URL: https://github.com/apache/orc/pull/611#issuecomment-757088292
Interesting. When I run it locally with `17-ea` java test, it works.
```
$ java -version
openjdk version "17-ea" 2021-09-14
OpenJDK Runtime Environment (build 17-ea+3-125)
OpenJDK 64-Bit Server VM (build 17-ea+3-125, mixed mode, sharing)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #611: ORC-713: Add Java 17-ea to GitHub action
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #611:
URL: https://github.com/apache/orc/pull/611#issuecomment-757380439
I merged https://github.com/apache/orc/pull/617 . Could you rebase this PR to the master branch once more, @williamhyun ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun edited a comment on pull request #611: ORC-713: Add Java 17-ea to GitHub action
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #611:
URL: https://github.com/apache/orc/pull/611#issuecomment-757088292
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun edited a comment on pull request #611: ORC-713: Add Java 17-ea to GitHub action
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #611:
URL: https://github.com/apache/orc/pull/611#issuecomment-757088292
Interesting. When I run it locally with `17-ea` java test, it works.
```
$ java -version
openjdk version "17-ea" 2021-09-14
OpenJDK Runtime Environment (build 17-ea+3-125)
OpenJDK 64-Bit Server VM (build 17-ea+3-125, mixed mode, sharing)
```
Test-out is the same.
```
$ make test-out
Scanning dependencies of target test-out
Test project /Users/dongjoon/APACHE/orc-merge/build
Start 1: orc-test
1/3 Test #1: orc-test ......................... Passed 3.91 sec
Start 2: java-test
2/3 Test #2: java-test ........................ Passed 76.84 sec
Start 3: tool-test
3/3 Test #3: tool-test ........................ Passed 15.58 sec
100% tests passed, 0 tests failed out of 3
Total Test time (real) = 96.34 sec
Built target test-out
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] williamhyun commented on pull request #611: ORC-713: Add Java 17-ea to GitHub action
Posted by GitBox <gi...@apache.org>.
williamhyun commented on pull request #611:
URL: https://github.com/apache/orc/pull/611#issuecomment-757086056
Thank you, I rebased @dongjoon-hyun.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #611: ORC-713: Add Java 17-ea to GitHub action
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #611:
URL: https://github.com/apache/orc/pull/611#issuecomment-757066039
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun merged pull request #611: ORC-713: Add Java 15 to GitHub action
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #611:
URL: https://github.com/apache/orc/pull/611
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #611: ORC-713: Add Java 17-ea to GitHub action
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #611:
URL: https://github.com/apache/orc/pull/611#issuecomment-757526358
For this one, shall we add `15` for now and call it a day? We can upgrade it from `15` to `16` and to `17` to track the upstream change and revisit again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #611: ORC-713: Add Java 17-ea to GitHub action
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #611:
URL: https://github.com/apache/orc/pull/611#issuecomment-757407408
Thank you for updating. The result is interesting. I'll take a look at that, too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #611: ORC-713: Add Java 17-ea to GitHub action
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #611:
URL: https://github.com/apache/orc/pull/611#issuecomment-757083685
FYI, I made a PR to `master` to clean up ancient libraries.
- https://github.com/apache/orc/pull/612
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #611: ORC-713: Add Java 17-ea to GitHub action
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #611:
URL: https://github.com/apache/orc/pull/611#issuecomment-757377679
No problem. I closed ORC-717 as a duplication of ORC-723 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] williamhyun commented on pull request #611: ORC-713: Add Java 17-ea to GitHub action
Posted by GitBox <gi...@apache.org>.
williamhyun commented on pull request #611:
URL: https://github.com/apache/orc/pull/611#issuecomment-757394648
I rebased, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #611: ORC-713: Add Java 17-ea to GitHub action
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #611:
URL: https://github.com/apache/orc/pull/611#issuecomment-757066887
According to the log, `mockito` can be a root cause. Could you upgrade `mockito-core` first in a separate PR, please?
```
java.lang.NoClassDefFoundError: Could not initialize class org.mockito.internal.creation.jmock.ClassImposterizer$3
956
at org.mockito.internal.creation.jmock.ClassImposterizer.createProxyClass(ClassImposterizer.java:85)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #611: ORC-713: Add Java 17-ea to GitHub action
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #611:
URL: https://github.com/apache/orc/pull/611#issuecomment-757085825
Could you rebase to the master branch, @williamhyun ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #611: ORC-713: Add Java 17-ea to GitHub action
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #611:
URL: https://github.com/apache/orc/pull/611#issuecomment-757409176
FYI, here is the difference.
```
$ jshell
| Welcome to JShell -- Version 11.0.9
| For an introduction type: /help intro
jshell> java.nio.Buffer.class.getDeclaredField("address").setAccessible(true)
```
```
$ jshell
| Welcome to JShell -- Version 17-ea
| For an introduction type: /help intro
jshell> java.nio.Buffer.class.getDeclaredField("address").setAccessible(true)
| Exception java.lang.reflect.InaccessibleObjectException: Unable to make field long java.nio.Buffer.address accessible: module java.base does not "opens java.nio" to unnamed module @6d03e736
| at AccessibleObject.checkCanSetAccessible (AccessibleObject.java:357)
| at AccessibleObject.checkCanSetAccessible (AccessibleObject.java:297)
| at Field.checkCanSetAccessible (Field.java:177)
| at Field.setAccessible (Field.java:171)
| at (#1:1)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #611: ORC-713: Add Java 17-ea to GitHub action
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #611:
URL: https://github.com/apache/orc/pull/611#issuecomment-757092461
For my previous comment, I created ORC-717. Feel free to pick up it if you have some time.
> According to the log, `mockito` can be a root cause. Could you upgrade `mockito-core` first in a separate PR, please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #611: ORC-713: Add Java 17-ea to GitHub action
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #611:
URL: https://github.com/apache/orc/pull/611#issuecomment-757066039
Thank you for making a PR, @williamhyun . Yes, Java 17 is important. It seems to fail on Java 17-ea for some reasons as of now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org