[jira] [Resolved] (KAFKA-322) Remove one-off Send objects

["Jay Kreps (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/KAFKA-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jay Kreps resolved KAFKA-322.
-----------------------------

    Resolution: Fixed

This was fixed a long while back, cleaning up.

> Remove one-off Send objects
> ---------------------------
>
>                 Key: KAFKA-322
>                 URL: https://issues.apache.org/jira/browse/KAFKA-322
>             Project: Kafka
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 0.8.0
>            Reporter: Jay Kreps
>            Assignee: Jay Kreps
>            Priority: Minor
>              Labels: replication
>             Fix For: 0.9.0
>
>
> We seem to be accumulating a bunch of unnecessary classes that implement Send. I am not sure why people are doing this. Example:
> ProducerResponseSend.scala
> It is not at all clear why we would add a custom send object for each request/response type. They all do the same thing. The only reason for having the concept of a Send object was to allow two implementations: ByteBufferSend and MessageSetSend, the later let's us abstract over the difference between a normal write and a sendfile() call.
> I think we can refactory ByteBufferSend to take one or more ByteBuffers instead of just one and delete all of these one-offs.



--
This message was sent by Atlassian JIRA
(v6.2#6252)