You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "dlmarion (via GitHub)" <gi...@apache.org> on 2024/02/15 21:53:52 UTC
[PR] Ensured that TabletMgmtStats are incremented in TabletGroupWatcher [accumulo]
dlmarion opened a new pull request, #4272:
URL: https://github.com/apache/accumulo/pull/4272
Fixes #4233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Ensured that TabletMgmtStats are incremented in TabletGroupWatcher [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #4272:
URL: https://github.com/apache/accumulo/pull/4272#discussion_r1497689933
##########
server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java:
##########
@@ -446,6 +446,7 @@ private TableMgmtStats manageTablets(Iterator<TabletManagement> iter,
state = newState;
}
}
+ tableMgmtStats.counts[state.ordinal()]++;
Review Comment:
Could this be moved to right after the computation of `state`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Ensured that TabletMgmtStats are incremented in TabletGroupWatcher [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion merged PR #4272:
URL: https://github.com/apache/accumulo/pull/4272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Ensured that TabletMgmtStats are incremented in TabletGroupWatcher [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on code in PR #4272:
URL: https://github.com/apache/accumulo/pull/4272#discussion_r1497703904
##########
server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java:
##########
@@ -446,6 +446,7 @@ private TableMgmtStats manageTablets(Iterator<TabletManagement> iter,
state = newState;
}
}
+ tableMgmtStats.counts[state.ordinal()]++;
Review Comment:
You are saying to move to right after line 421? Are you saying we don't need to capture the possible state change on line 446?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Ensured that TabletMgmtStats are incremented in TabletGroupWatcher [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #4272:
URL: https://github.com/apache/accumulo/pull/4272#discussion_r1497744098
##########
server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java:
##########
@@ -446,6 +446,7 @@ private TableMgmtStats manageTablets(Iterator<TabletManagement> iter,
state = newState;
}
}
+ tableMgmtStats.counts[state.ordinal()]++;
Review Comment:
nevermind, I missed that... do want to capture that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org