You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/02/27 12:16:24 UTC
[GitHub] [hive] dengzhhu653 opened a new pull request #1958: HIVE-24752: Returned operation's drilldown link may be broken
dengzhhu653 opened a new pull request #1958:
URL: https://github.com/apache/hive/pull/1958
https://issues.apache.org/jira/browse/HIVE-24752
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
Local machine
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on a change in pull request #1958: HIVE-24752: Returned operation's drilldown link may be broken
Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on a change in pull request #1958:
URL: https://github.com/apache/hive/pull/1958#discussion_r584008875
##########
File path: beeline/src/main/resources/beeline-log4j2.properties
##########
@@ -33,12 +33,16 @@ appender.console.layout.type = PatternLayout
appender.console.layout.pattern = %d{yy/MM/dd HH:mm:ss} [%t]: %p %c{2}: %m%n
# list of all loggers
-loggers = HiveConnection
+loggers = HiveConnection, HiveStatement
# HiveConnection logs useful info for dynamic service discovery
logger.HiveConnection.name = org.apache.hive.jdbc.HiveConnection
logger.HiveConnection.level = INFO
+# HiveStatement logs for tracking the running statement, such as the operation's drilldown link
+logger.HiveStatement.name = org.apache.hive.jdbc.HiveStatement
Review comment:
Fine, I moved the other minor parts into the https://github.com/apache/hive/pull/1992, could you please take a look at the PR-1992?
Thanks,
Zhihua Deng
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary merged pull request #1958: HIVE-24752: Returned operation's drilldown link may be broken
Posted by GitBox <gi...@apache.org>.
pvary merged pull request #1958:
URL: https://github.com/apache/hive/pull/1958
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on a change in pull request #1958: HIVE-24752: Returned operation's drilldown link may be broken
Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on a change in pull request #1958:
URL: https://github.com/apache/hive/pull/1958#discussion_r580244082
##########
File path: beeline/src/main/resources/beeline-log4j2.properties
##########
@@ -33,12 +33,16 @@ appender.console.layout.type = PatternLayout
appender.console.layout.pattern = %d{yy/MM/dd HH:mm:ss} [%t]: %p %c{2}: %m%n
# list of all loggers
-loggers = HiveConnection
+loggers = HiveConnection, HiveStatement
# HiveConnection logs useful info for dynamic service discovery
logger.HiveConnection.name = org.apache.hive.jdbc.HiveConnection
logger.HiveConnection.level = INFO
+# HiveStatement logs for tracking the running statement, such as the operation's drilldown link
+logger.HiveStatement.name = org.apache.hive.jdbc.HiveStatement
Review comment:
Most of the logs in HiveStatement are in debug level, showing the process of excuting a statement. Here enable it because we want to enable showing the operation display link at the beginning of executing the statement when using beeline.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on pull request #1958: HIVE-24752: Returned operation's drilldown link may be broken
Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on pull request #1958:
URL: https://github.com/apache/hive/pull/1958#issuecomment-787460314
> Please unsubscribe me
> […](#)
> On Tue, Feb 16, 2021, 5:49 PM dengzh ***@***.*** wrote: @kgyrtkirk <https://github.com/kgyrtkirk> @belugabehr <https://github.com/belugabehr> could you please take a look? thanks... — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <[#1958 (comment)](https://github.com/apache/hive/pull/1958#issuecomment-779801254)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC4NUFA3J3FN5BW6A64GRVTS7JPGZANCNFSM4XI7TRCQ> .
Hey @searlapati , are you mean unsubscribing to the mailing lists? Please send an empty email to: user-unsubscribe@hive.apache.org for unsubscribing yourself.
https://hive.apache.org/mailing_lists.html
Thanks, Zhihua Deng
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on pull request #1958: HIVE-24752: Returned operation's drilldown link may be broken
Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on pull request #1958:
URL: https://github.com/apache/hive/pull/1958#issuecomment-779801254
@kgyrtkirk @belugabehr could you please take a look? thanks...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on a change in pull request #1958: HIVE-24752: Returned operation's drilldown link may be broken
Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on a change in pull request #1958:
URL: https://github.com/apache/hive/pull/1958#discussion_r580329748
##########
File path: beeline/src/main/resources/beeline-log4j2.properties
##########
@@ -33,12 +33,16 @@ appender.console.layout.type = PatternLayout
appender.console.layout.pattern = %d{yy/MM/dd HH:mm:ss} [%t]: %p %c{2}: %m%n
# list of all loggers
-loggers = HiveConnection
+loggers = HiveConnection, HiveStatement
# HiveConnection logs useful info for dynamic service discovery
logger.HiveConnection.name = org.apache.hive.jdbc.HiveConnection
logger.HiveConnection.level = INFO
+# HiveStatement logs for tracking the running statement, such as the operation's drilldown link
+logger.HiveStatement.name = org.apache.hive.jdbc.HiveStatement
Review comment:
@pvary Yes, I tried on local test, the link is displayed on beeline only if the config is enabled as well as adding the HiveStatement(loggers) to the beeline-log4j2.properties.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a change in pull request #1958: HIVE-24752: Returned operation's drilldown link may be broken
Posted by GitBox <gi...@apache.org>.
pvary commented on a change in pull request #1958:
URL: https://github.com/apache/hive/pull/1958#discussion_r584042856
##########
File path: beeline/src/main/resources/beeline-log4j2.properties
##########
@@ -33,12 +33,16 @@ appender.console.layout.type = PatternLayout
appender.console.layout.pattern = %d{yy/MM/dd HH:mm:ss} [%t]: %p %c{2}: %m%n
# list of all loggers
-loggers = HiveConnection
+loggers = HiveConnection, HiveStatement
# HiveConnection logs useful info for dynamic service discovery
logger.HiveConnection.name = org.apache.hive.jdbc.HiveConnection
logger.HiveConnection.level = INFO
+# HiveStatement logs for tracking the running statement, such as the operation's drilldown link
+logger.HiveStatement.name = org.apache.hive.jdbc.HiveStatement
Review comment:
@dengzhhu653: Please do mix fixes / changes in PRs only if necessary. This helps backport work easier. If you could remove the log config changes from this one, then I could merge this PR, and we can continue to the next one.
Thanks, Peter
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on pull request #1958: HIVE-24752: Returned operation's drilldown link may be broken
Posted by GitBox <gi...@apache.org>.
pvary commented on pull request #1958:
URL: https://github.com/apache/hive/pull/1958#issuecomment-792623862
Thanks for the patch @dengzhhu653 and @marton-bod for the review!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 closed pull request #1958: HIVE-24752: Returned operation's drilldown link may be broken
Posted by GitBox <gi...@apache.org>.
dengzhhu653 closed pull request #1958:
URL: https://github.com/apache/hive/pull/1958
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a change in pull request #1958: HIVE-24752: Returned operation's drilldown link may be broken
Posted by GitBox <gi...@apache.org>.
pvary commented on a change in pull request #1958:
URL: https://github.com/apache/hive/pull/1958#discussion_r583484011
##########
File path: beeline/src/main/resources/beeline-log4j2.properties
##########
@@ -33,12 +33,16 @@ appender.console.layout.type = PatternLayout
appender.console.layout.pattern = %d{yy/MM/dd HH:mm:ss} [%t]: %p %c{2}: %m%n
# list of all loggers
-loggers = HiveConnection
+loggers = HiveConnection, HiveStatement
# HiveConnection logs useful info for dynamic service discovery
logger.HiveConnection.name = org.apache.hive.jdbc.HiveConnection
logger.HiveConnection.level = INFO
+# HiveStatement logs for tracking the running statement, such as the operation's drilldown link
+logger.HiveStatement.name = org.apache.hive.jdbc.HiveStatement
Review comment:
@dengzhhu653: There are some users who have hard expectations on the stdout/stderr for BeeLine processes. I think we should keep the original behavior here. If someone is interested they can change the config on their own deployment.
Thanks,
Peter
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 closed pull request #1958: HIVE-24752: Returned operation's drilldown link may be broken
Posted by GitBox <gi...@apache.org>.
dengzhhu653 closed pull request #1958:
URL: https://github.com/apache/hive/pull/1958
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on a change in pull request #1958: HIVE-24752: Returned operation's drilldown link may be broken
Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on a change in pull request #1958:
URL: https://github.com/apache/hive/pull/1958#discussion_r584050092
##########
File path: beeline/src/main/resources/beeline-log4j2.properties
##########
@@ -33,12 +33,16 @@ appender.console.layout.type = PatternLayout
appender.console.layout.pattern = %d{yy/MM/dd HH:mm:ss} [%t]: %p %c{2}: %m%n
# list of all loggers
-loggers = HiveConnection
+loggers = HiveConnection, HiveStatement
# HiveConnection logs useful info for dynamic service discovery
logger.HiveConnection.name = org.apache.hive.jdbc.HiveConnection
logger.HiveConnection.level = INFO
+# HiveStatement logs for tracking the running statement, such as the operation's drilldown link
+logger.HiveStatement.name = org.apache.hive.jdbc.HiveStatement
Review comment:
ok, done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on a change in pull request #1958: HIVE-24752: Returned operation's drilldown link may be broken
Posted by GitBox <gi...@apache.org>.
pvary commented on a change in pull request #1958:
URL: https://github.com/apache/hive/pull/1958#discussion_r580321214
##########
File path: beeline/src/main/resources/beeline-log4j2.properties
##########
@@ -33,12 +33,16 @@ appender.console.layout.type = PatternLayout
appender.console.layout.pattern = %d{yy/MM/dd HH:mm:ss} [%t]: %p %c{2}: %m%n
# list of all loggers
-loggers = HiveConnection
+loggers = HiveConnection, HiveStatement
# HiveConnection logs useful info for dynamic service discovery
logger.HiveConnection.name = org.apache.hive.jdbc.HiveConnection
logger.HiveConnection.level = INFO
+# HiveStatement logs for tracking the running statement, such as the operation's drilldown link
+logger.HiveStatement.name = org.apache.hive.jdbc.HiveStatement
Review comment:
@dengzhhu653: I think showing the link should be decided based on this method:
```
if (sessionManager.getOperationManager().canShowDrilldownLink(operationHandle)) {
```
Are you saying that this is not working as expected? Even if the config is enabled and the line is appended to the info messages then it is not displayed on BeeLine?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on pull request #1958: HIVE-24752: Returned operation's drilldown link may be broken
Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on pull request #1958:
URL: https://github.com/apache/hive/pull/1958#issuecomment-782546764
Hi @pvary @marton-bod any comments?
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] marton-bod commented on a change in pull request #1958: HIVE-24752: Returned operation's drilldown link may be broken
Posted by GitBox <gi...@apache.org>.
marton-bod commented on a change in pull request #1958:
URL: https://github.com/apache/hive/pull/1958#discussion_r580217037
##########
File path: beeline/src/main/resources/beeline-log4j2.properties
##########
@@ -33,12 +33,16 @@ appender.console.layout.type = PatternLayout
appender.console.layout.pattern = %d{yy/MM/dd HH:mm:ss} [%t]: %p %c{2}: %m%n
# list of all loggers
-loggers = HiveConnection
+loggers = HiveConnection, HiveStatement
# HiveConnection logs useful info for dynamic service discovery
logger.HiveConnection.name = org.apache.hive.jdbc.HiveConnection
logger.HiveConnection.level = INFO
+# HiveStatement logs for tracking the running statement, such as the operation's drilldown link
+logger.HiveStatement.name = org.apache.hive.jdbc.HiveStatement
Review comment:
Are we sure we want to add more logging to Beeline? @pvary do we have any general guidelines on what could/should be logged in beeline?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] dengzhhu653 commented on a change in pull request #1958: HIVE-24752: Returned operation's drilldown link may be broken
Posted by GitBox <gi...@apache.org>.
dengzhhu653 commented on a change in pull request #1958:
URL: https://github.com/apache/hive/pull/1958#discussion_r584008875
##########
File path: beeline/src/main/resources/beeline-log4j2.properties
##########
@@ -33,12 +33,16 @@ appender.console.layout.type = PatternLayout
appender.console.layout.pattern = %d{yy/MM/dd HH:mm:ss} [%t]: %p %c{2}: %m%n
# list of all loggers
-loggers = HiveConnection
+loggers = HiveConnection, HiveStatement
# HiveConnection logs useful info for dynamic service discovery
logger.HiveConnection.name = org.apache.hive.jdbc.HiveConnection
logger.HiveConnection.level = INFO
+# HiveStatement logs for tracking the running statement, such as the operation's drilldown link
+logger.HiveStatement.name = org.apache.hive.jdbc.HiveStatement
Review comment:
Fine, I moved the other minor parts into the https://github.com/apache/hive/pull/1992, could you please take a look at the PR-1992? Thank you...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] searlapati commented on pull request #1958: HIVE-24752: Returned operation's drilldown link may be broken
Posted by GitBox <gi...@apache.org>.
searlapati commented on pull request #1958:
URL: https://github.com/apache/hive/pull/1958#issuecomment-787134393
Please unsubscribe me
On Tue, Feb 16, 2021, 5:49 PM dengzh <notifications@github.com wrote:
> @kgyrtkirk <https://github.com/kgyrtkirk> @belugabehr
> <https://github.com/belugabehr> could you please take a look? thanks...
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/hive/pull/1958#issuecomment-779801254>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AC4NUFA3J3FN5BW6A64GRVTS7JPGZANCNFSM4XI7TRCQ>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org