You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2014/11/11 23:44:20 UTC

Review Request 27887: Remove experimental flag for the features that are already part of ambari (addendum patch)

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27887/
-----------------------------------------------------------

Review request for Ambari, Andrii Tkach and Yusaku Sako.


Bugs: AMBARI-7963
    https://issues.apache.org/jira/browse/AMBARI-7963


Repository: ambari


Description
-------

There are references mainly to supports.hostOverrides flag in the code which were not deleted in the initial commit.
Addendum patch for this ticket deletes such references.


Diffs
-----

  ambari-web/app/controllers/wizard/step7_controller.js a7f4251 
  ambari-web/app/routes/add_host_routes.js e5e92b3 
  ambari-web/app/views/common/configs/services_config.js a822aa2 
  ambari-web/app/views/main/host/summary.js fe431d8 
  ambari-web/app/views/main/menu.js 1988d02 
  ambari-web/test/utils/config_test.js 5dec0ae 
  ambari-web/test/views/main/menu_test.js d60bace 

Diff: https://reviews.apache.org/r/27887/diff/


Testing
-------

tested e2e.


Thanks,

Jaimin Jetly


Re: Review Request 27887: Remove experimental flag for the features that are already part of ambari (addendum patch)

Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27887/#review60913
-----------------------------------------------------------

Ship it!


Ship It!

- Yusaku Sako


On Nov. 12, 2014, 12:58 a.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27887/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2014, 12:58 a.m.)
> 
> 
> Review request for Ambari, Andrii Tkach and Yusaku Sako.
> 
> 
> Bugs: AMBARI-7963
>     https://issues.apache.org/jira/browse/AMBARI-7963
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> There are references mainly to supports.hostOverrides flag in the code which were not deleted in the initial commit.
> Addendum patch for this ticket deletes such references.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/wizard/step7_controller.js a7f4251 
>   ambari-web/app/routes/add_host_routes.js e5e92b3 
>   ambari-web/app/views/common/configs/services_config.js a822aa2 
>   ambari-web/app/views/main/host/summary.js fe431d8 
>   ambari-web/app/views/main/menu.js 1988d02 
>   ambari-web/test/utils/config_test.js 5dec0ae 
>   ambari-web/test/views/main/menu_test.js d60bace 
> 
> Diff: https://reviews.apache.org/r/27887/diff/
> 
> 
> Testing
> -------
> 
> tested e2e.
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>


Re: Review Request 27887: Remove experimental flag for the features that are already part of ambari (addendum patch)

Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27887/
-----------------------------------------------------------

(Updated Nov. 12, 2014, 12:58 a.m.)


Review request for Ambari, Andrii Tkach and Yusaku Sako.


Changes
-------

Removed occurences of App.supports.mirroring


Bugs: AMBARI-7963
    https://issues.apache.org/jira/browse/AMBARI-7963


Repository: ambari


Description
-------

There are references mainly to supports.hostOverrides flag in the code which were not deleted in the initial commit.
Addendum patch for this ticket deletes such references.


Diffs (updated)
-----

  ambari-web/app/controllers/wizard/step7_controller.js a7f4251 
  ambari-web/app/routes/add_host_routes.js e5e92b3 
  ambari-web/app/views/common/configs/services_config.js a822aa2 
  ambari-web/app/views/main/host/summary.js fe431d8 
  ambari-web/app/views/main/menu.js 1988d02 
  ambari-web/test/utils/config_test.js 5dec0ae 
  ambari-web/test/views/main/menu_test.js d60bace 

Diff: https://reviews.apache.org/r/27887/diff/


Testing
-------

tested e2e.


Thanks,

Jaimin Jetly


Re: Review Request 27887: Remove experimental flag for the features that are already part of ambari (addendum patch)

Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27887/#review60902
-----------------------------------------------------------



ambari-web/app/views/main/menu.js
<https://reviews.apache.org/r/27887/#comment102304>

    Remove App.supports.mirroring.


- Yusaku Sako


On Nov. 11, 2014, 10:44 p.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27887/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2014, 10:44 p.m.)
> 
> 
> Review request for Ambari, Andrii Tkach and Yusaku Sako.
> 
> 
> Bugs: AMBARI-7963
>     https://issues.apache.org/jira/browse/AMBARI-7963
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> There are references mainly to supports.hostOverrides flag in the code which were not deleted in the initial commit.
> Addendum patch for this ticket deletes such references.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/wizard/step7_controller.js a7f4251 
>   ambari-web/app/routes/add_host_routes.js e5e92b3 
>   ambari-web/app/views/common/configs/services_config.js a822aa2 
>   ambari-web/app/views/main/host/summary.js fe431d8 
>   ambari-web/app/views/main/menu.js 1988d02 
>   ambari-web/test/utils/config_test.js 5dec0ae 
>   ambari-web/test/views/main/menu_test.js d60bace 
> 
> Diff: https://reviews.apache.org/r/27887/diff/
> 
> 
> Testing
> -------
> 
> tested e2e.
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>