You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by xubo245 <gi...@git.apache.org> on 2018/11/01 03:18:02 UTC
[GitHub] carbondata pull request #2890: [CARBONDATA-3002] Fix some spell error
GitHub user xubo245 opened a pull request:
https://github.com/apache/carbondata/pull/2890
[CARBONDATA-3002] Fix some spell error
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
No
- [ ] Any backward compatibility impacted?
No
- [ ] Document update required?
No
- [ ] Testing done
only change spell error
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xubo245/carbondata CARBONDATA-3002_FixSpellError3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2890.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2890
----
commit 097160b78f154f3616505d0e78ff9a198878aa1e
Author: xubo245 <xu...@...>
Date: 2018-11-01T03:16:43Z
[CARBONDATA-3002] Fix some spell error
----
---
[GitHub] carbondata issue #2890: [CARBONDATA-3002] Fix some spell error
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2890
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1418/
---
[GitHub] carbondata issue #2890: [CARBONDATA-3002] Fix some spell error
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2890
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1771/
---
[GitHub] carbondata issue #2890: [CARBONDATA-3002] Fix some spell error
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2890
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1967/
---
[GitHub] carbondata issue #2890: [CARBONDATA-3002] Fix some spell error
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2890
@jackylk @chenliang613 CI pass, please handle it.
---
[GitHub] carbondata issue #2890: [CARBONDATA-3002] Fix some spell error
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2890
Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9625/
---
[GitHub] carbondata pull request #2890: [CARBONDATA-3002] Fix some spell error
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2890
---
[GitHub] carbondata pull request #2890: [CARBONDATA-3002] Fix some spell error
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2890#discussion_r241735498
--- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonLoaderUtil.java ---
@@ -569,25 +569,25 @@ public static Dictionary getDictionary(AbsoluteTableIdentifier absoluteTableIden
nodes.add(relation.getNode());
}
- int noofNodes = (-1 == noOfNodesInput) ? nodes.size() : noOfNodesInput;
+ int noOfNodes = (-1 == noOfNodesInput) ? nodes.size() : noOfNodesInput;
--- End diff --
```suggestion
int numNodes = (-1 == noOfNodesInput) ? nodes.size() : numNodesInput;
```
---
[GitHub] carbondata issue #2890: [CARBONDATA-3002] Fix some spell error
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2890
Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9621/
---
[GitHub] carbondata issue #2890: [CARBONDATA-3002] Fix some spell error
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2890
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1756/
---
[GitHub] carbondata issue #2890: [CARBONDATA-3002] Fix some spell error
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2890
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1203/
---
[GitHub] carbondata issue #2890: [CARBONDATA-3002] Fix some spell error
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2890
retest this please
---
[GitHub] carbondata issue #2890: [CARBONDATA-3002] Fix some spell error
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2890
Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9467/
---
[GitHub] carbondata issue #2890: [CARBONDATA-3002] Fix some spell error
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2890
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1573/
---
[GitHub] carbondata issue #2890: [CARBONDATA-3002] Fix some spell error
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2890
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1579/
---
[GitHub] carbondata issue #2890: [CARBONDATA-3002] Fix some spell error
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2890
Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10015/
---
[GitHub] carbondata issue #2890: [CARBONDATA-3002] Fix some spell error
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2890
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1577/
---
[GitHub] carbondata pull request #2890: [CARBONDATA-3002] Fix some spell error
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2890#discussion_r241795430
--- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonLoaderUtil.java ---
@@ -569,25 +569,25 @@ public static Dictionary getDictionary(AbsoluteTableIdentifier absoluteTableIden
nodes.add(relation.getNode());
}
- int noofNodes = (-1 == noOfNodesInput) ? nodes.size() : noOfNodesInput;
+ int noOfNodes = (-1 == noOfNodesInput) ? nodes.size() : noOfNodesInput;
--- End diff --
I change noOfNodes to numOfNodes, there are more than 100+ place use numOf__,
Do I need optimize noOfXXX to numOfXXX in similar code?
---
[GitHub] carbondata issue #2890: [CARBONDATA-3002] Fix some spell error
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2890
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1750/
---
[GitHub] carbondata issue #2890: [CARBONDATA-3002] Fix some spell error
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2890
rebase
---
[GitHub] carbondata issue #2890: [CARBONDATA-3002] Fix some spell error
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2890
@chenliang613 @jackylk How to handle this PR?
---
[GitHub] carbondata issue #2890: [CARBONDATA-3002] Fix some spell error
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2890
Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10009/
---
[GitHub] carbondata issue #2890: [CARBONDATA-3002] Fix some spell error
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2890
LGTM
---
[GitHub] carbondata issue #2890: [CARBONDATA-3002] Fix some spell error
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2890
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1984/
---
[GitHub] carbondata issue #2890: [CARBONDATA-3002] Fix some spell error
Posted by brijoobopanna <gi...@git.apache.org>.
Github user brijoobopanna commented on the issue:
https://github.com/apache/carbondata/pull/2890
retest this please
---
[GitHub] carbondata issue #2890: [CARBONDATA-3002] Fix some spell error
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2890
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1961/
---
[GitHub] carbondata issue #2890: [CARBONDATA-3002] Fix some spell error
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2890
@brijoobopanna @chenliang613 @jackylk CI pass. please check again.
---
[GitHub] carbondata issue #2890: [CARBONDATA-3002] Fix some spell error
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2890
LGTM
---
[GitHub] carbondata issue #2890: [CARBONDATA-3002] Fix some spell error
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2890
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1363/
---
[GitHub] carbondata issue #2890: [CARBONDATA-3002] Fix some spell error
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2890
Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10031/
---
[GitHub] carbondata issue #2890: [CARBONDATA-3002] Fix some spell error
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2890
Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9627/
---
[GitHub] carbondata issue #2890: [CARBONDATA-3002] Fix some spell error
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2890
@jackylk @chenliang613 CI pass, please handle it.
---
[GitHub] carbondata issue #2890: [CARBONDATA-3002] Fix some spell error
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2890
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1370/
---
[GitHub] carbondata issue #2890: [CARBONDATA-3002] Fix some spell error
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2890
retest this please
---
[GitHub] carbondata issue #2890: [CARBONDATA-3002] Fix some spell error
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2890
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1367/
---