You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2022/05/30 13:18:16 UTC
[commons-lang] branch master updated (cf8d9737e -> 2477d7970)
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-lang.git
from cf8d9737e Organize imports
new e8cccb8ef Add synchronized like super
new c7d56ecb7 Document unused type parameter for tests
new 702d66190 Add synchronized like super
new 2477d7970 Document unused for tests
The 4 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../java/org/apache/commons/lang3/ClassUtilsTest.java | 1 +
.../commons/lang3/exception/ExceptionUtilsTest.java | 2 +-
.../org/apache/commons/lang3/reflect/TypeUtilsTest.java | 15 +++++++++++++++
.../commons/lang3/test/NotVisibleExceptionFactory.java | 2 +-
4 files changed, 18 insertions(+), 2 deletions(-)
[commons-lang] 04/04: Document unused for tests
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-lang.git
commit 2477d7970f4a52fce6a5f7aa3c6197ccda0ebc4e
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Mon May 30 09:18:11 2022 -0400
Document unused for tests
---
src/test/java/org/apache/commons/lang3/ClassUtilsTest.java | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/test/java/org/apache/commons/lang3/ClassUtilsTest.java b/src/test/java/org/apache/commons/lang3/ClassUtilsTest.java
index d3caeb400..70f2928e9 100644
--- a/src/test/java/org/apache/commons/lang3/ClassUtilsTest.java
+++ b/src/test/java/org/apache/commons/lang3/ClassUtilsTest.java
@@ -56,6 +56,7 @@ public class ClassUtilsTest {
// empty
}
+ @SuppressWarnings("unused") // IB is redundant but what a test checks
private static class CY extends CX implements IB, IC {
// empty
}
[commons-lang] 03/04: Add synchronized like super
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-lang.git
commit 702d661907c4dbed6caeaffa89c17efb550c4f8b
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Mon May 30 09:14:43 2022 -0400
Add synchronized like super
---
.../java/org/apache/commons/lang3/exception/ExceptionUtilsTest.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/test/java/org/apache/commons/lang3/exception/ExceptionUtilsTest.java b/src/test/java/org/apache/commons/lang3/exception/ExceptionUtilsTest.java
index 10fd6af2c..767e3d9d9 100644
--- a/src/test/java/org/apache/commons/lang3/exception/ExceptionUtilsTest.java
+++ b/src/test/java/org/apache/commons/lang3/exception/ExceptionUtilsTest.java
@@ -67,7 +67,7 @@ public class ExceptionUtilsTest {
}
@Override
- public Throwable getCause() {
+ public synchronized Throwable getCause() {
return cause;
}
[commons-lang] 01/04: Add synchronized like super
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-lang.git
commit e8cccb8efb09b7f044a748e2367923a731d72773
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Mon May 30 09:11:14 2022 -0400
Add synchronized like super
---
.../org/apache/commons/lang3/reflect/TypeUtilsTest.java | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/src/test/java/org/apache/commons/lang3/reflect/TypeUtilsTest.java b/src/test/java/org/apache/commons/lang3/reflect/TypeUtilsTest.java
index 60fe2095f..365540948 100644
--- a/src/test/java/org/apache/commons/lang3/reflect/TypeUtilsTest.java
+++ b/src/test/java/org/apache/commons/lang3/reflect/TypeUtilsTest.java
@@ -51,12 +51,15 @@ import org.junit.jupiter.api.Test;
class AAAClass extends AAClass<String> {
public class BBBClass extends BBClass<String> {
+ // empty
}
}
+@SuppressWarnings("unused") // Unused type parameter for test
class AAClass<T> {
public class BBClass<S> {
+ // empty
}
}
@@ -64,25 +67,37 @@ class AAClass<T> {
//raw types, where used, are used purposely
class AClass extends AAClass<String>.BBClass<Number> {
+ @SuppressWarnings("unused") // Unused type parameter for test
public interface AInterface<T> {
+ // empty
}
+ @SuppressWarnings("unused") // Unused type parameter for test
public class BClass<T> {
+ // empty
}
+ @SuppressWarnings("unused") // Unused type parameter for test
public class CClass<T> extends BClass {
+ // empty
}
+ @SuppressWarnings("unused") // Unused type parameter for test
public class DClass<T> extends CClass<T> {
+ // empty
}
+ @SuppressWarnings("unused") // Unused type parameter for test
public class EClass<T> extends DClass {
+ // empty
}
public class FClass extends EClass<String> {
+ // empty
}
public class GClass<T extends BClass<? extends T> & AInterface<AInterface<? super T>>> {
+ // empty
}
public BClass<Number> bClass;
[commons-lang] 02/04: Document unused type parameter for tests
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-lang.git
commit c7d56ecb7009016fe1992cb5a92a58962a1ae1c5
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Mon May 30 09:14:20 2022 -0400
Document unused type parameter for tests
---
.../java/org/apache/commons/lang3/test/NotVisibleExceptionFactory.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/test/java/org/apache/commons/lang3/test/NotVisibleExceptionFactory.java b/src/test/java/org/apache/commons/lang3/test/NotVisibleExceptionFactory.java
index c5bb1befe..79e077f78 100644
--- a/src/test/java/org/apache/commons/lang3/test/NotVisibleExceptionFactory.java
+++ b/src/test/java/org/apache/commons/lang3/test/NotVisibleExceptionFactory.java
@@ -45,7 +45,7 @@ public class NotVisibleExceptionFactory {
}
@Override
- public Throwable getCause() {
+ public synchronized Throwable getCause() {
return cause;
}
}