You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2019/02/21 20:08:09 UTC
Re: Review Request 69287: Added test cases for the `volume/host_path`
isolator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69287/#review213047
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/containerizer/volume_host_path_isolator_tests.cpp
Lines 30 (patched)
<https://reviews.apache.org/r/69287/#comment298910>
newline above
src/tests/containerizer/volume_host_path_isolator_tests.cpp
Lines 51 (patched)
<https://reviews.apache.org/r/69287/#comment298911>
ditto
- Gilbert Song
On Nov. 7, 2018, 2:06 p.m., Jason Lai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69287/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2018, 2:06 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Eric Chung, Gilbert Song, Jie Yu, and James Peach.
>
>
> Bugs: MESOS-9009
> https://issues.apache.org/jira/browse/MESOS-9009
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test cases for the `volume/host_path` isolator for whitelisted
> non-existing host paths.
>
>
> Diffs
> -----
>
> src/tests/containerizer/volume_host_path_isolator_tests.cpp 81bf72e869d36edb162b121f9e84a53d2096dae3
>
>
> Diff: https://reviews.apache.org/r/69287/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Jason Lai
>
>
Re: Review Request 69287: Added test cases for the `volume/host_path`
isolator.
Posted by Jason Lai <ja...@jasonlai.net>.
> On Feb. 21, 2019, 8:08 p.m., Gilbert Song wrote:
> > src/tests/containerizer/volume_host_path_isolator_tests.cpp
> > Lines 30 (patched)
> > <https://reviews.apache.org/r/69287/diff/1/?file=2106294#file2106294line30>
> >
> > newline above
Done.
> On Feb. 21, 2019, 8:08 p.m., Gilbert Song wrote:
> > src/tests/containerizer/volume_host_path_isolator_tests.cpp
> > Lines 51 (patched)
> > <https://reviews.apache.org/r/69287/diff/1/?file=2106294#file2106294line51>
> >
> > ditto
Done.
- Jason
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69287/#review213047
-----------------------------------------------------------
On Nov. 7, 2018, 10:06 p.m., Jason Lai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69287/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2018, 10:06 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Eric Chung, Gilbert Song, Jie Yu, and James Peach.
>
>
> Bugs: MESOS-9009
> https://issues.apache.org/jira/browse/MESOS-9009
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test cases for the `volume/host_path` isolator for whitelisted
> non-existing host paths.
>
>
> Diffs
> -----
>
> src/tests/containerizer/volume_host_path_isolator_tests.cpp 81bf72e869d36edb162b121f9e84a53d2096dae3
>
>
> Diff: https://reviews.apache.org/r/69287/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Jason Lai
>
>