[jira] [Commented] (OFBIZ-6268) Improve Start.java Component Loading

["Jacopo Cappellato (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14504682#comment-14504682 ] 

Jacopo Cappellato commented on OFBIZ-6268:
------------------------------------------

Thank you Adrian.
What I don't like about this new approach is that it adds to the "framework/start" module a dependency on the inner layout of the "base" component:
{code}
            classPath.addComponent(ofbizHomeTmp.concat("framework/base/config"));
            classPath.addComponent(ofbizHomeTmp.concat("framework/base/dtd"));
            classPath.addFilesFromPath(new File(ofbizHomeTmp.concat("framework/base/lib")));
            classPath.addFilesFromPath(new File(ofbizHomeTmp.concat("framework/base/lib/commons")));
            classPath.addComponent(ofbizHomeTmp.concat("framework/base/build/lib/ofbiz-base.jar"));
{code}
while with the current code the dependency is just on the "layout" of the OFBiz folder:
{code}
        collectClasspathEntries(new File(home, "framework"), classPath, libraryPath);
        collectClasspathEntries(new File(home, "applications"), classPath, libraryPath);
        collectClasspathEntries(new File(home, "specialpurpose"), classPath, libraryPath);
        collectClasspathEntries(new File(home, "hot-deploy"), classPath, libraryPath);
{code}

Moreover, does the new code introduce any changes to the ClassLoader tree? (i.e. a new ClassLoader in the parent-child path)
I am asking because it is difficult for me to figure out by reviewing the patch.
If it adds new levels, even if this is not a big deal, then we should decide if it is worth to improve startup performance and penalize runtime performance (both by tiny fractions).

> Improve Start.java Component Loading
> ------------------------------------
>
>                 Key: OFBIZ-6268
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6268
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Upcoming Branch
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: OFBIZ-6268.patch
>
>
> The current code for loading components parses configuration files twice. This issue is intended for review of code improvements.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)