[GitHub] [arrow] mqy commented on pull request #9299: ARROW-11179: [Format] Make FB comments friendly to rust

[GitBox <gi...@apache.org>]

mqy commented on pull request #9299:
URL: https://github.com/apache/arrow/pull/9299#issuecomment-767312376


   @pitrou @emkornfield thanks!
   
   > Looks OK to me as well, is it possible to generate one off docs with this change to confirm the figures look OK?
   
   As of `rust`, files `rust/arrow/src/ipc/gen/*.rs` on remote `master` branch had been generated with this patch. I've test locally with `cargo test --doc` and `cargo doc` -- no errors/warnings and the figures looks good like this:
   
   ```
           0          1
          / \         |
         0   1        1
        /   / \       |
       0   0   1      1
      /|  /|   |    /| |
     1 2 0 2   0   0 1 2
   ```
   
   For `cpp` or other languages that copy comments into generated codes,  perhaps it's better to verify that this patch is sound.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org