You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "leosanqing (via GitHub)" <gi...@apache.org> on 2024/08/23 09:10:17 UTC
[PR] [FLINK-36143][ES6][ES7] Intro retry-on-conflict param to resolve Sink ES occurred "version conflict" [flink-connector-elasticsearch]
leosanqing opened a new pull request, #109:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/109
When I used ES connector Write update datas, it occurred "version conflict", like this " org.elasticsearch.index.engine.VersionConflictEngineException: [project][1140860]: version conflict, current version [5] is different than the one provided [4]
"
When we set the conf failure-handler = ignore, It lead to lost data, and if set the conf failure-handler = fail, job will restore. this cost is too heavy. maybe second try it will success.
so I intro this conf param, this will make job failed cost smaller.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36143][ES6][ES7] Intro retry-on-conflict param to resolve Sink ES occurred "version conflict" [flink-connector-elasticsearch]
Posted by "leosanqing (via GitHub)" <gi...@apache.org>.
leosanqing commented on PR #109:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/109#issuecomment-2333325477
@reswqa @mtfelisb hi guys,could you review my pr? thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36143][ES6][ES7] Intro retry-on-conflict param to resolve Sink ES occurred "version conflict" [flink-connector-elasticsearch]
Posted by "leosanqing (via GitHub)" <gi...@apache.org>.
leosanqing commented on PR #109:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/109#issuecomment-2320267238
Thanks for your advices，and I fixed this. Has anybody can review my code?
> Thank you for your patch! I am not an official maintainer. Your changes look reasonable, however, they lack test coverage. One other thing I noticed: The newly introduced constant `RETRY_ON_CONFLICT_NUM` does not follow the naming convention of other config options in `ElasticsearchConnectorOptions`: Most of them appear to end on `[...]_OPTION` but do not have the type-indicating suffix. Renaming it to `sink.retries-on-conflict` could eliminate the confusion wether this is a boolean flag or a number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36143][ES6][ES7] Intro retry-on-conflict param to resolve Sink ES occurred "version conflict" [flink-connector-elasticsearch]
Posted by "leosanqing (via GitHub)" <gi...@apache.org>.
leosanqing commented on PR #109:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/109#issuecomment-2312079949
@schulzp @alpinegizmo @aljoscha @rmetzger Has any body to review my code? thk ❤️❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36143][ES6][ES7] Intro retry-on-conflict param to resolve Sink ES occurred "version conflict" [flink-connector-elasticsearch]
Posted by "leosanqing (via GitHub)" <gi...@apache.org>.
leosanqing commented on PR #109:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/109#issuecomment-2333434088
@rmetzger hi, thx for your triggering. I see there has some error when run IT case. And there also has same error in before PR . Is there some problems in project? The leatest merged pr doesn't have this step, latest un-merged PRs both have this error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36143][ES6][ES7] Intro retry-on-conflict param to resolve Sink ES occurred "version conflict" [flink-connector-elasticsearch]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #109:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/109#issuecomment-2306651224
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org