[GitHub] sijie commented on a change in pull request #729: Issue 550: add readLastAddConfirmedAndEntry in ReadHandle for long poll read

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #729: Issue 550: add readLastAddConfirmedAndEntry in ReadHandle for long poll read
URL: https://github.com/apache/bookkeeper/pull/729#discussion_r151261333
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/ReadHandle.java
 ##########
 @@ -111,4 +112,32 @@
      */
     long getLength();
 
+    /**
+     * The type contains LAC and a LedgerEntry want to read.
+     * It is used for readLastAddConfirmedAndEntry.
+     */
+    @Data
+    class LastConfirmedAndEntry {
 
 Review comment:
   move it out of ReadHandle.java, make it an interface
   
   ```
   interface LastConfirmedAndEntry extends AutoCloseable {
   
        long getLastAddConfirmed();
   
        boolean hasEntry();
   
        LedgerEntry getEntry();
   
   }
   ```
   
   create a class LastConfirmedAndEntryImpl to implement the interface.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services