You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/07/15 01:16:29 UTC
[GitHub] [commons-csv] belugabehr opened a new pull request #168: CSV-284: Formalize PerformanceTest
belugabehr opened a new pull request #168:
URL: https://github.com/apache/commons-csv/pull/168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] garydgregory commented on a change in pull request #168: CSV-284: Formalize PerformanceTest
Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #168:
URL: https://github.com/apache/commons-csv/pull/168#discussion_r670056091
##########
File path: src/test/java/org/apache/commons/csv/perf/PerformanceTest.java
##########
@@ -85,24 +85,12 @@ private long parse(final Reader reader, final boolean traverseColumns) throws IO
return recordCount;
}
- private void println(final String s) {
- System.out.println(s);
- }
-
- private long readAll(final BufferedReader in) throws IOException {
Review comment:
I disagree here, keep this as is so it can be commented out or changed easily when testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] coveralls commented on pull request #168: CSV-284: Formalize PerformanceTest
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #168:
URL: https://github.com/apache/commons-csv/pull/168#issuecomment-880324653
[](https://coveralls.io/builds/41384366)
Coverage remained the same at 98.31% when pulling **77896a74c4dace7deabfb056b01cc0f0f9bdc858 on belugabehr:CSV-284** into **a2ba9b52886162d7f046ff7fe8019c1ba5334a9a on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] garydgregory merged pull request #168: CSV-284: Formalize PerformanceTest
Posted by GitBox <gi...@apache.org>.
garydgregory merged pull request #168:
URL: https://github.com/apache/commons-csv/pull/168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] belugabehr commented on a change in pull request #168: CSV-284: Formalize PerformanceTest
Posted by GitBox <gi...@apache.org>.
belugabehr commented on a change in pull request #168:
URL: https://github.com/apache/commons-csv/pull/168#discussion_r670058570
##########
File path: src/test/java/org/apache/commons/csv/perf/PerformanceTest.java
##########
@@ -85,24 +85,12 @@ private long parse(final Reader reader, final boolean traverseColumns) throws IO
return recordCount;
}
- private void println(final String s) {
- System.out.println(s);
- }
-
- private long readAll(final BufferedReader in) throws IOException {
Review comment:
You got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org