Re: [PR] [FLINK-40467] Randomise application result store paths [flink-kubernetes-operator]

["dalelane (via GitHub)" <gi...@apache.org>]

dalelane commented on code in PR #1199:
URL: https://github.com/apache/flink-kubernetes-operator/pull/1199#discussion_r3914063062


##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/ApplicationReconciler.java:
##########
@@ -273,6 +285,24 @@ private static void setRandomJobResultStorePath(Configuration effectiveConfig) {
         }
     }
 
+    private static void setRandomApplicationResultStorePath(Configuration effectiveConfig) {
+        if (effectiveConfig.contains(HighAvailabilityOptions.HA_STORAGE_PATH)) {
+            // The application result store shares the HA storage path, which outlives
+            // the HA metadata deleted on upgrade. Dirty entries are recovered unkeyed,
+            // so a terminal entry left behind by a previous deployment makes the
+            // replacement cluster skip submitting the new job.
+            // Giving each deployment a unique path makes sure that nothing stale is
+            // recovered.
+            effectiveConfig.set(

Review Comment:
   I didn't think this was necessary - the config option was only added in FLINK-38975 for Flink 2.3, so in earlier versions of Flink, isn't this non-existent config value just going to be silently ignored? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org