You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Antonio Petrelli (JIRA)" <ji...@apache.org> on 2007/02/08 17:30:16 UTC

[jira] Created: (WW-1724) No content-type header in Tiles Result response

No content-type header in Tiles Result response
-----------------------------------------------

                 Key: WW-1724
                 URL: https://issues.apache.org/struts/browse/WW-1724
             Project: Struts 2
          Issue Type: Bug
          Components: Plugins
    Affects Versions: 2.0.5
         Environment: JBoss-4.0.5.GA/Tomcat-5.5
            Reporter: Antonio Petrelli


Following is the description of the problem, as reported by Elin Heinstedt:

When forwarding from an action to a tiles result the content-type of the response is empty.

* The tiles result i defined in a tiles definition file:

<definition name="tiles.letters" template="/tilesResult.jsp">
<put name="content" value="/tile-letters.jsp" />
</definition>


* The tilesResult.jsp uses insertAttribute:

<tiles:insertAttribute name="content" />


* Each page declares the contentType UTF-8:

<%@ page contentType="text/html; charset=UTF-8" %>


* If a Disptacher Result a used instead of the TilesResult the content-type of the response is text/html; charset=UTF-8.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (WW-1724) No content-type header in Tiles Result response

Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antonio Petrelli reassigned WW-1724:
------------------------------------

    Assignee: Antonio Petrelli

> No content-type header in Tiles Result response
> -----------------------------------------------
>
>                 Key: WW-1724
>                 URL: https://issues.apache.org/struts/browse/WW-1724
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugins
>    Affects Versions: 2.0.5
>         Environment: JBoss-4.0.5.GA/Tomcat-5.5
>            Reporter: Antonio Petrelli
>            Assignee: Antonio Petrelli
>             Fix For: 2.0.10
>
>
> Following is the description of the problem, as reported by Elin Heinstedt:
> When forwarding from an action to a tiles result the content-type of the response is empty.
> * The tiles result i defined in a tiles definition file:
> <definition name="tiles.letters" template="/tilesResult.jsp">
> <put name="content" value="/tile-letters.jsp" />
> </definition>
> * The tilesResult.jsp uses insertAttribute:
> <tiles:insertAttribute name="content" />
> * Each page declares the contentType UTF-8:
> <%@ page contentType="text/html; charset=UTF-8" %>
> * If a Disptacher Result a used instead of the TilesResult the content-type of the response is text/html; charset=UTF-8.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WW-1724) No content-type header in Tiles Result response

Posted by "Don Brown (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Don Brown updated WW-1724:
--------------------------

    Fix Version/s:     (was: 2.0.8)
                   2.0.9

If the issue has been resolved for non-Freemarker results, then that should cover 95% of Tiles users.  Moving to the next release...

> No content-type header in Tiles Result response
> -----------------------------------------------
>
>                 Key: WW-1724
>                 URL: https://issues.apache.org/struts/browse/WW-1724
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugins
>    Affects Versions: 2.0.5
>         Environment: JBoss-4.0.5.GA/Tomcat-5.5
>            Reporter: Antonio Petrelli
>             Fix For: 2.0.9
>
>
> Following is the description of the problem, as reported by Elin Heinstedt:
> When forwarding from an action to a tiles result the content-type of the response is empty.
> * The tiles result i defined in a tiles definition file:
> <definition name="tiles.letters" template="/tilesResult.jsp">
> <put name="content" value="/tile-letters.jsp" />
> </definition>
> * The tilesResult.jsp uses insertAttribute:
> <tiles:insertAttribute name="content" />
> * Each page declares the contentType UTF-8:
> <%@ page contentType="text/html; charset=UTF-8" %>
> * If a Disptacher Result a used instead of the TilesResult the content-type of the response is text/html; charset=UTF-8.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WW-1724) No content-type header in Tiles Result response

Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_41491 ] 

Antonio Petrelli commented on WW-1724:
--------------------------------------

I forgot to merge from the trunk to the 2.0 branch.
Now it is merged.
It is still open the FreeMarker support question, though.

> No content-type header in Tiles Result response
> -----------------------------------------------
>
>                 Key: WW-1724
>                 URL: https://issues.apache.org/struts/browse/WW-1724
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugins
>    Affects Versions: 2.0.5
>         Environment: JBoss-4.0.5.GA/Tomcat-5.5
>            Reporter: Antonio Petrelli
>             Fix For: 2.0.9
>
>
> Following is the description of the problem, as reported by Elin Heinstedt:
> When forwarding from an action to a tiles result the content-type of the response is empty.
> * The tiles result i defined in a tiles definition file:
> <definition name="tiles.letters" template="/tilesResult.jsp">
> <put name="content" value="/tile-letters.jsp" />
> </definition>
> * The tilesResult.jsp uses insertAttribute:
> <tiles:insertAttribute name="content" />
> * Each page declares the contentType UTF-8:
> <%@ page contentType="text/html; charset=UTF-8" %>
> * If a Disptacher Result a used instead of the TilesResult the content-type of the response is text/html; charset=UTF-8.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WW-1724) No content-type header in Tiles Result response

Posted by "James Holmes (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James Holmes updated WW-1724:
-----------------------------

    Fix Version/s:     (was: 2.0.9)
                   2.0.10

Moving to 2.0.10 so that 2.0.9 can be released.

> No content-type header in Tiles Result response
> -----------------------------------------------
>
>                 Key: WW-1724
>                 URL: https://issues.apache.org/struts/browse/WW-1724
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugins
>    Affects Versions: 2.0.5
>         Environment: JBoss-4.0.5.GA/Tomcat-5.5
>            Reporter: Antonio Petrelli
>             Fix For: 2.0.10
>
>
> Following is the description of the problem, as reported by Elin Heinstedt:
> When forwarding from an action to a tiles result the content-type of the response is empty.
> * The tiles result i defined in a tiles definition file:
> <definition name="tiles.letters" template="/tilesResult.jsp">
> <put name="content" value="/tile-letters.jsp" />
> </definition>
> * The tilesResult.jsp uses insertAttribute:
> <tiles:insertAttribute name="content" />
> * Each page declares the contentType UTF-8:
> <%@ page contentType="text/html; charset=UTF-8" %>
> * If a Disptacher Result a used instead of the TilesResult the content-type of the response is text/html; charset=UTF-8.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WW-1724) No content-type header in Tiles Result response

Posted by "Ted Husted (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Husted updated WW-1724:
---------------------------

    Fix Version/s: 2.0.7

> No content-type header in Tiles Result response
> -----------------------------------------------
>
>                 Key: WW-1724
>                 URL: https://issues.apache.org/struts/browse/WW-1724
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugins
>    Affects Versions: 2.0.5
>         Environment: JBoss-4.0.5.GA/Tomcat-5.5
>            Reporter: Antonio Petrelli
>             Fix For: 2.0.7
>
>
> Following is the description of the problem, as reported by Elin Heinstedt:
> When forwarding from an action to a tiles result the content-type of the response is empty.
> * The tiles result i defined in a tiles definition file:
> <definition name="tiles.letters" template="/tilesResult.jsp">
> <put name="content" value="/tile-letters.jsp" />
> </definition>
> * The tilesResult.jsp uses insertAttribute:
> <tiles:insertAttribute name="content" />
> * Each page declares the contentType UTF-8:
> <%@ page contentType="text/html; charset=UTF-8" %>
> * If a Disptacher Result a used instead of the TilesResult the content-type of the response is text/html; charset=UTF-8.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WW-1724) No content-type header in Tiles Result response

Posted by "Olivier Lamy (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40854 ] 

Olivier Lamy commented on WW-1724:
----------------------------------

No news on this.
I have try to fix this with the simple fix (in TilesResult class).

    public void doExecute( String location, ActionInvocation invocation )
        throws Exception
    {
        setLocation( location );

        ServletContext servletContext = ServletActionContext.getServletContext();
        TilesContainer container = TilesAccess.getContainer( servletContext );

        HttpServletRequest request = ServletActionContext.getRequest();
        HttpServletResponse response = ServletActionContext.getResponse();
// forcing the content type 
        response.setContentType( "text/html; charset=UTF-8" );
        container.render( request, response, location );
    }

And it works.
Any chance to have this integrated in svn ?

> No content-type header in Tiles Result response
> -----------------------------------------------
>
>                 Key: WW-1724
>                 URL: https://issues.apache.org/struts/browse/WW-1724
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugins
>    Affects Versions: 2.0.5
>         Environment: JBoss-4.0.5.GA/Tomcat-5.5
>            Reporter: Antonio Petrelli
>             Fix For: 2.0.8
>
>
> Following is the description of the problem, as reported by Elin Heinstedt:
> When forwarding from an action to a tiles result the content-type of the response is empty.
> * The tiles result i defined in a tiles definition file:
> <definition name="tiles.letters" template="/tilesResult.jsp">
> <put name="content" value="/tile-letters.jsp" />
> </definition>
> * The tilesResult.jsp uses insertAttribute:
> <tiles:insertAttribute name="content" />
> * Each page declares the contentType UTF-8:
> <%@ page contentType="text/html; charset=UTF-8" %>
> * If a Disptacher Result a used instead of the TilesResult the content-type of the response is text/html; charset=UTF-8.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WW-1724) No content-type header in Tiles Result response

Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antonio Petrelli resolved WW-1724.
----------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 2.0.10)
                   2.0.9

The fixes work also for FreeMarker.
I just added another example in the showcase to show how a layout page made with FreeMarker leads to a correct "content-type".

> No content-type header in Tiles Result response
> -----------------------------------------------
>
>                 Key: WW-1724
>                 URL: https://issues.apache.org/struts/browse/WW-1724
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugins
>    Affects Versions: 2.0.5
>         Environment: JBoss-4.0.5.GA/Tomcat-5.5
>            Reporter: Antonio Petrelli
>            Assignee: Antonio Petrelli
>             Fix For: 2.0.9
>
>
> Following is the description of the problem, as reported by Elin Heinstedt:
> When forwarding from an action to a tiles result the content-type of the response is empty.
> * The tiles result i defined in a tiles definition file:
> <definition name="tiles.letters" template="/tilesResult.jsp">
> <put name="content" value="/tile-letters.jsp" />
> </definition>
> * The tilesResult.jsp uses insertAttribute:
> <tiles:insertAttribute name="content" />
> * Each page declares the contentType UTF-8:
> <%@ page contentType="text/html; charset=UTF-8" %>
> * If a Disptacher Result a used instead of the TilesResult the content-type of the response is text/html; charset=UTF-8.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (WW-1724) No content-type header in Tiles Result response

Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antonio Petrelli reassigned WW-1724:
------------------------------------

    Assignee: Antonio Petrelli

> No content-type header in Tiles Result response
> -----------------------------------------------
>
>                 Key: WW-1724
>                 URL: https://issues.apache.org/struts/browse/WW-1724
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugins
>    Affects Versions: 2.0.5
>         Environment: JBoss-4.0.5.GA/Tomcat-5.5
>            Reporter: Antonio Petrelli
>         Assigned To: Antonio Petrelli
>
> Following is the description of the problem, as reported by Elin Heinstedt:
> When forwarding from an action to a tiles result the content-type of the response is empty.
> * The tiles result i defined in a tiles definition file:
> <definition name="tiles.letters" template="/tilesResult.jsp">
> <put name="content" value="/tile-letters.jsp" />
> </definition>
> * The tilesResult.jsp uses insertAttribute:
> <tiles:insertAttribute name="content" />
> * Each page declares the contentType UTF-8:
> <%@ page contentType="text/html; charset=UTF-8" %>
> * If a Disptacher Result a used instead of the TilesResult the content-type of the response is text/html; charset=UTF-8.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (WW-1724) No content-type header in Tiles Result response

Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antonio Petrelli reassigned WW-1724:
------------------------------------

    Assignee:     (was: Antonio Petrelli)

I corrected the problem for non-FreeMarker results, but for FreeMarker it still includes always the result, then the content-type will not be present in this case.
I remove the "assign to" tag, because I really don't know what to do.

> No content-type header in Tiles Result response
> -----------------------------------------------
>
>                 Key: WW-1724
>                 URL: https://issues.apache.org/struts/browse/WW-1724
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugins
>    Affects Versions: 2.0.5
>         Environment: JBoss-4.0.5.GA/Tomcat-5.5
>            Reporter: Antonio Petrelli
>
> Following is the description of the problem, as reported by Elin Heinstedt:
> When forwarding from an action to a tiles result the content-type of the response is empty.
> * The tiles result i defined in a tiles definition file:
> <definition name="tiles.letters" template="/tilesResult.jsp">
> <put name="content" value="/tile-letters.jsp" />
> </definition>
> * The tilesResult.jsp uses insertAttribute:
> <tiles:insertAttribute name="content" />
> * Each page declares the contentType UTF-8:
> <%@ page contentType="text/html; charset=UTF-8" %>
> * If a Disptacher Result a used instead of the TilesResult the content-type of the response is text/html; charset=UTF-8.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WW-1724) No content-type header in Tiles Result response

Posted by "Umesh Kudtarkar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40885 ] 

Umesh Kudtarkar commented on WW-1724:
-------------------------------------

Is there any chance this will be fixed by 2.0.8 release. We are currently using tiles extensively and could not ship application without this fix.

Thanks,
Umesh

> No content-type header in Tiles Result response
> -----------------------------------------------
>
>                 Key: WW-1724
>                 URL: https://issues.apache.org/struts/browse/WW-1724
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugins
>    Affects Versions: 2.0.5
>         Environment: JBoss-4.0.5.GA/Tomcat-5.5
>            Reporter: Antonio Petrelli
>             Fix For: 2.0.8
>
>
> Following is the description of the problem, as reported by Elin Heinstedt:
> When forwarding from an action to a tiles result the content-type of the response is empty.
> * The tiles result i defined in a tiles definition file:
> <definition name="tiles.letters" template="/tilesResult.jsp">
> <put name="content" value="/tile-letters.jsp" />
> </definition>
> * The tilesResult.jsp uses insertAttribute:
> <tiles:insertAttribute name="content" />
> * Each page declares the contentType UTF-8:
> <%@ page contentType="text/html; charset=UTF-8" %>
> * If a Disptacher Result a used instead of the TilesResult the content-type of the response is text/html; charset=UTF-8.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.