You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/04/04 17:09:16 UTC
[GitHub] [helix] junkaixue opened a new pull request, #2014: Fix web build and deployment Issue
junkaixue opened a new pull request, #2014:
URL: https://github.com/apache/helix/pull/2014
### Issues
- [] My PR addresses the following Helix issues and references them in the PR description:
### Description
- [X] Here are some details about my PR, including screenshots of any UI changes:
It adds a repository to download from more than default Maven Central. Restlet files are missing from Maven Central. Force it to download from Maven Central can cause problem.
### Tests
- [ ] The following tests are written for this issue:
- The following is the result of the "mvn test" command on the appropriate module:
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Apache Helix :: Website ............................ SUCCESS [ 12.801 s]
[INFO] Apache Helix :: Website :: 0.9.8 ................... SUCCESS [ 7.016 s]
[INFO] Apache Helix :: Website :: 0.9.9 ................... SUCCESS [ 5.505 s]
[INFO] Apache Helix :: Website :: 1.0.1 ................... SUCCESS [ 5.600 s]
[INFO] Apache Helix :: Website :: 1.0.2 ................... SUCCESS [ 5.409 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 42.091 s
[INFO] Finished at: 2022-04-04T10:07:54-07:00
[INFO] Final Memory: 64M/960M
[INFO] ------------------------------------------------------------------------
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue commented on a diff in pull request #2014: Fix web build and deployment Issue
Posted by GitBox <gi...@apache.org>.
junkaixue commented on code in PR #2014:
URL: https://github.com/apache/helix/pull/2014#discussion_r841971277
##########
pom.xml:
##########
@@ -334,16 +334,6 @@
<enabled>false</enabled>
</snapshots>
</repository>
- <repository>
Review Comment:
No. This only impact website as we bump the plugin version last time. I got the guidance from Apache Maven folks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue commented on pull request #2014: Fix web build and deployment Issue
Posted by GitBox <gi...@apache.org>.
junkaixue commented on PR #2014:
URL: https://github.com/apache/helix/pull/2014#issuecomment-1087812388
This change is ready to be merged. Approved by @desaikomal
Commit message:
Fix website build and deployment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue merged pull request #2014: Fix web build and deployment Issue
Posted by GitBox <gi...@apache.org>.
junkaixue merged PR #2014:
URL: https://github.com/apache/helix/pull/2014
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly commented on a diff in pull request #2014: Fix web build and deployment Issue
Posted by GitBox <gi...@apache.org>.
narendly commented on code in PR #2014:
URL: https://github.com/apache/helix/pull/2014#discussion_r841969144
##########
pom.xml:
##########
@@ -334,16 +334,6 @@
<enabled>false</enabled>
</snapshots>
</repository>
- <repository>
Review Comment:
Does this not break builds for other modules?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org