You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by John Speidel <js...@hortonworks.com> on 2014/11/26 19:52:04 UTC
Review Request 28475: Add new "add hosts" API which accepts host name,
blueprint name and host group name
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28475/
-----------------------------------------------------------
Review request for Ambari, Nate Cole, Robert Nettleton, and Tom Beerbower.
Bugs: AMBARI-8458
https://issues.apache.org/jira/browse/AMBARI-8458
Repository: ambari
Description
-------
Provide a higher level api for host provisioning.
This api will accept a host name, blueprint name and host group.
The result of this api call will be fully operational hosts added to the existing cluster with configuration and components which are defined in the specified blueprint/host_group. All components on the added hosts will be installed and started.
All hosts must be reachable via ambari server and have the ambari agent running and registered with the ambari server prior to using this api.
* See the associated Jira for more including API examples.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java 5af88a8
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 7d08a7b
ambari-server/src/main/java/org/apache/ambari/server/controller/HostRequest.java b577bb0
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractResourceProvider.java 2c9179d
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseBlueprintProcessor.java 9be73cc
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterControllerImpl.java 352e0ad
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java bb6a39c
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java c73a8d4
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java 4600538
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java c53eb78
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 945a4db
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java e3f6d4b
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 1f57397
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java f7149a8
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java abe30cc
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java cab75ee
Diff: https://reviews.apache.org/r/28475/diff/
Testing
-------
- New unit tests added
- All unit tests pass
- Functional testing of the new API
Thanks,
John Speidel
Re: Review Request 28475: Add new "add hosts" API which accepts host
name, blueprint name and host group name
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28475/#review63138
-----------------------------------------------------------
Ship it!
Looks fine.
- Robert Nettleton
On Nov. 26, 2014, 6:52 p.m., John Speidel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28475/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2014, 6:52 p.m.)
>
>
> Review request for Ambari, Nate Cole, Robert Nettleton, and Tom Beerbower.
>
>
> Bugs: AMBARI-8458
> https://issues.apache.org/jira/browse/AMBARI-8458
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Provide a higher level api for host provisioning.
> This api will accept a host name, blueprint name and host group.
> The result of this api call will be fully operational hosts added to the existing cluster with configuration and components which are defined in the specified blueprint/host_group. All components on the added hosts will be installed and started.
> All hosts must be reachable via ambari server and have the ambari agent running and registered with the ambari server prior to using this api.
>
>
> * See the associated Jira for more including API examples.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java 5af88a8
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 7d08a7b
> ambari-server/src/main/java/org/apache/ambari/server/controller/HostRequest.java b577bb0
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractResourceProvider.java 2c9179d
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseBlueprintProcessor.java 9be73cc
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterControllerImpl.java 352e0ad
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java bb6a39c
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java c73a8d4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java 4600538
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java c53eb78
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 945a4db
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java e3f6d4b
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 1f57397
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java f7149a8
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java abe30cc
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java cab75ee
>
> Diff: https://reviews.apache.org/r/28475/diff/
>
>
> Testing
> -------
>
> - New unit tests added
> - All unit tests pass
> - Functional testing of the new API
>
>
> Thanks,
>
> John Speidel
>
>
Re: Review Request 28475: Add new "add hosts" API which accepts host
name, blueprint name and host group name
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28475/#review63129
-----------------------------------------------------------
Ship it!
Looks good.
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
<https://reviews.apache.org/r/28475/#comment105325>
Could/should this be private?
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java
<https://reviews.apache.org/r/28475/#comment105326>
nice!
- Tom Beerbower
On Nov. 26, 2014, 6:52 p.m., John Speidel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28475/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2014, 6:52 p.m.)
>
>
> Review request for Ambari, Nate Cole, Robert Nettleton, and Tom Beerbower.
>
>
> Bugs: AMBARI-8458
> https://issues.apache.org/jira/browse/AMBARI-8458
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Provide a higher level api for host provisioning.
> This api will accept a host name, blueprint name and host group.
> The result of this api call will be fully operational hosts added to the existing cluster with configuration and components which are defined in the specified blueprint/host_group. All components on the added hosts will be installed and started.
> All hosts must be reachable via ambari server and have the ambari agent running and registered with the ambari server prior to using this api.
>
>
> * See the associated Jira for more including API examples.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java 5af88a8
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 7d08a7b
> ambari-server/src/main/java/org/apache/ambari/server/controller/HostRequest.java b577bb0
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractResourceProvider.java 2c9179d
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseBlueprintProcessor.java 9be73cc
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterControllerImpl.java 352e0ad
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java bb6a39c
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java c73a8d4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java 4600538
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java c53eb78
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 945a4db
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java e3f6d4b
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 1f57397
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java f7149a8
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java abe30cc
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java cab75ee
>
> Diff: https://reviews.apache.org/r/28475/diff/
>
>
> Testing
> -------
>
> - New unit tests added
> - All unit tests pass
> - Functional testing of the new API
>
>
> Thanks,
>
> John Speidel
>
>