You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Till Toenshoff <to...@me.com> on 2014/05/23 02:47:59 UTC
Review Request 21833: Fixed MesosContainerizerExecuteTest.IoRedirection for
OSX.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21833/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-1413
https://issues.apache.org/jira/browse/MESOS-1413
Repository: mesos-git
Description
-------
see summary
Diffs
-----
src/tests/containerizer_tests.cpp 2f4888d
Diff: https://reviews.apache.org/r/21833/diff/
Testing
-------
make check (OSX and linux)
Thanks,
Till Toenshoff
Re: Review Request 21833: Fixed MesosContainerizerExecuteTest.IoRedirection
for OSX.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21833/#review44050
-----------------------------------------------------------
Ship it!
Ship It!
- Ian Downes
On May 22, 2014, 5:47 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21833/
> -----------------------------------------------------------
>
> (Updated May 22, 2014, 5:47 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1413
> https://issues.apache.org/jira/browse/MESOS-1413
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/tests/containerizer_tests.cpp 2f4888d
>
> Diff: https://reviews.apache.org/r/21833/diff/
>
>
> Testing
> -------
>
> make check (OSX and linux)
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 21833: Fixed MesosContainerizerExecuteTest.IoRedirection
for OSX.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21833/#review44064
-----------------------------------------------------------
src/tests/containerizer_tests.cpp
<https://reviews.apache.org/r/21833/#comment78375>
It's incorrect in that it doesn't verify that the streams go to the correct files.
- Ian Downes
On May 27, 2014, 3:42 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21833/
> -----------------------------------------------------------
>
> (Updated May 27, 2014, 3:42 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1413
> https://issues.apache.org/jira/browse/MESOS-1413
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/tests/containerizer_tests.cpp 2f4888d
>
> Diff: https://reviews.apache.org/r/21833/diff/
>
>
> Testing
> -------
>
> make check (OSX and linux)
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 21833: Fixed MesosContainerizerExecuteTest.IoRedirection
for OSX.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21833/#review44063
-----------------------------------------------------------
Ship it!
Ship It!
- Dominic Hamon
On May 27, 2014, 3:42 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21833/
> -----------------------------------------------------------
>
> (Updated May 27, 2014, 3:42 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1413
> https://issues.apache.org/jira/browse/MESOS-1413
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/tests/containerizer_tests.cpp 2f4888d
>
> Diff: https://reviews.apache.org/r/21833/diff/
>
>
> Testing
> -------
>
> make check (OSX and linux)
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 21833: Fixed MesosContainerizerExecuteTest.IoRedirection
for OSX.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21833/
-----------------------------------------------------------
(Updated May 27, 2014, 10:42 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Fixed stdout-message to actually output stdout.
Bugs: MESOS-1413
https://issues.apache.org/jira/browse/MESOS-1413
Repository: mesos-git
Description
-------
see summary
Diffs (updated)
-----
src/tests/containerizer_tests.cpp 2f4888d
Diff: https://reviews.apache.org/r/21833/diff/
Testing
-------
make check (OSX and linux)
Thanks,
Till Toenshoff
Re: Review Request 21833: Fixed MesosContainerizerExecuteTest.IoRedirection
for OSX.
Posted by Dominic Hamon <dh...@twopensource.com>.
> On May 27, 2014, 2:48 p.m., Ian Downes wrote:
> > src/tests/containerizer_tests.cpp, line 462
> > <https://reviews.apache.org/r/21833/diff/1/?file=588592#file588592line462>
> >
> > Let's change this to use printf, as suggested in `man echo`, to not output the \n.
looking over the rest of the code, we use 'echo' and compare with the '\n'. for consistency maybe leaving this as echo is better?
- Dominic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21833/#review44047
-----------------------------------------------------------
On May 22, 2014, 5:47 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21833/
> -----------------------------------------------------------
>
> (Updated May 22, 2014, 5:47 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1413
> https://issues.apache.org/jira/browse/MESOS-1413
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/tests/containerizer_tests.cpp 2f4888d
>
> Diff: https://reviews.apache.org/r/21833/diff/
>
>
> Testing
> -------
>
> make check (OSX and linux)
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 21833: Fixed MesosContainerizerExecuteTest.IoRedirection
for OSX.
Posted by Till Toenshoff <to...@me.com>.
> On May 27, 2014, 9:48 p.m., Ian Downes wrote:
> > src/tests/containerizer_tests.cpp, line 460
> > <https://reviews.apache.org/r/21833/diff/1/?file=588592#file588592line460>
> >
> > could you also correct the string here to "this is stdout".
How did this ever work? :)
> On May 27, 2014, 9:48 p.m., Ian Downes wrote:
> > src/tests/containerizer_tests.cpp, line 462
> > <https://reviews.apache.org/r/21833/diff/1/?file=588592#file588592line462>
> >
> > Let's change this to use printf, as suggested in `man echo`, to not output the \n.
>
> Dominic Hamon wrote:
> looking over the rest of the code, we use 'echo' and compare with the '\n'. for consistency maybe leaving this as echo is better?
>
> Ian Downes wrote:
> works for me! :-)
Suggested a proper cleanup in MESOS-1424. For the sake of consistency, I will drop this issue.
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21833/#review44047
-----------------------------------------------------------
On May 27, 2014, 10:42 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21833/
> -----------------------------------------------------------
>
> (Updated May 27, 2014, 10:42 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1413
> https://issues.apache.org/jira/browse/MESOS-1413
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/tests/containerizer_tests.cpp 2f4888d
>
> Diff: https://reviews.apache.org/r/21833/diff/
>
>
> Testing
> -------
>
> make check (OSX and linux)
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 21833: Fixed MesosContainerizerExecuteTest.IoRedirection
for OSX.
Posted by Ian Downes <ia...@gmail.com>.
> On May 27, 2014, 2:48 p.m., Ian Downes wrote:
> > src/tests/containerizer_tests.cpp, line 462
> > <https://reviews.apache.org/r/21833/diff/1/?file=588592#file588592line462>
> >
> > Let's change this to use printf, as suggested in `man echo`, to not output the \n.
>
> Dominic Hamon wrote:
> looking over the rest of the code, we use 'echo' and compare with the '\n'. for consistency maybe leaving this as echo is better?
works for me! :-)
- Ian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21833/#review44047
-----------------------------------------------------------
On May 22, 2014, 5:47 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21833/
> -----------------------------------------------------------
>
> (Updated May 22, 2014, 5:47 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1413
> https://issues.apache.org/jira/browse/MESOS-1413
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/tests/containerizer_tests.cpp 2f4888d
>
> Diff: https://reviews.apache.org/r/21833/diff/
>
>
> Testing
> -------
>
> make check (OSX and linux)
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 21833: Fixed MesosContainerizerExecuteTest.IoRedirection
for OSX.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21833/#review44047
-----------------------------------------------------------
src/tests/containerizer_tests.cpp
<https://reviews.apache.org/r/21833/#comment78357>
could you also correct the string here to "this is stdout".
src/tests/containerizer_tests.cpp
<https://reviews.apache.org/r/21833/#comment78356>
Let's change this to use printf, as suggested in `man echo`, to not output the \n.
- Ian Downes
On May 22, 2014, 5:47 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21833/
> -----------------------------------------------------------
>
> (Updated May 22, 2014, 5:47 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1413
> https://issues.apache.org/jira/browse/MESOS-1413
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/tests/containerizer_tests.cpp 2f4888d
>
> Diff: https://reviews.apache.org/r/21833/diff/
>
>
> Testing
> -------
>
> make check (OSX and linux)
>
>
> Thanks,
>
> Till Toenshoff
>
>