svn-push crashes (under cygwin)

[Mathias Weinert <ma...@gfa-net.de>]

Hi there,

I am trying to run svn-push for several hours now but I always get segmentation
faults or assertions. I built svn-push with revision 14711 from branches/1.2.x
after building subversion itself ('make' and then 'make svn-push') (I did this
using cygwin). The build seems to be okay but every call to svn-push leads to a
crash. This happens if I use svn:// as well as if I use file://.

Is there anyone who made svn-push run? Perhaps even with cygwin?
I would be happy if I could get a clue what to do to make svn-push run.
Many thanks!

Mathias

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn-push crashes (under cygwin)

[Philip Martin <ph...@codematters.co.uk>]

"Max Bowsher" <ma...@ukf.net> writes:

> Thanks for the report, I've discovered a bug in svn-push.c.
>
> Change the NULL parameter in the ra_src->do_diff() call to an empty
> string, i.e.  "" .

If we assume that svn-push did, at one time, work then it appears that
NULL was once a valid argument to do_diff and that Subversion has
changed.  At a guess I'd say that the reporter rewrite (r8840) which
happened just after 1.0, and just after svn-push was first committed,
is responsible.  In earlier versions set_path used svn_path_join_many
and the NULL would not have been a problem.

The current documentation for svn_ra_do_diff it states that
diff_target is "optional", I'm not sure what this means but it looks
like further evidence that NULL used to be valid.

-- 
Philip Martin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn-push crashes (under cygwin)

[Max Bowsher <ma...@ukf.net>]

Mathias Weinert wrote:
> Hi there,
>
> I am trying to run svn-push for several hours now but I always get
> segmentation faults or assertions. I built svn-push with revision 14711
> from branches/1.2.x after building subversion itself ('make' and then 
> 'make
> svn-push') (I did this using cygwin). The build seems to be okay but every
> call to svn-push leads to a crash. This happens if I use svn:// as well as
> if I use file://.
>
> Is there anyone who made svn-push run? Perhaps even with cygwin?
> I would be happy if I could get a clue what to do to make svn-push run.

Thanks for the report, I've discovered a bug in svn-push.c.

Change the NULL parameter in the ra_src->do_diff() call to an empty string, 
i.e.  "" .

I'll commit that now.

As you have experienced, "contrib" code is not thoughroughly tested or 
maintained.

Max.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org