You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/10/24 04:07:16 UTC

[GitHub] [hive] ayushtkn commented on a change in pull request #1605: HIVE-23935. Fetching primaryKey through beeline fails with NPE

ayushtkn commented on a change in pull request #1605:
URL: https://github.com/apache/hive/pull/1605#discussion_r511305357



##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
##########
@@ -10833,7 +10833,8 @@ public FileMetadataHandler getFileMetadataHandler(FileMetadataExprType type) {
                                                      final String db_name_input,
                                                      final String tbl_name_input)
   throws MetaException, NoSuchObjectException {
-    final String db_name = normalizeIdentifier(db_name_input);
+    final String db_name =

Review comment:
       Thanx @ashish-kumar-sharma 
   1. I will address.
   2. Why for catName? It isn't getting accessed anywhere which can fetch any NPE.
   3. I didn't catch this? I haven't introduce any variable itself.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org