[GitHub] [airflow] potiuk edited a comment on pull request #15589: [Oracle] Add port to DSN

[GitBox <gi...@apache.org>]

potiuk edited a comment on pull request #15589:
URL: https://github.com/apache/airflow/pull/15589#issuecomment-829428066


   > So if we want host:port/<something> to be translated back to host:port/<something>, then it seems conn.schema is the way to go.
   
   Hmm. I think this is not how (at least originally) the oracle connection was designed so far - it never mentions schema in the docs and it makes a clear distinction between SID (seems older system) and Service_name  - seems like a new one.
   
   The docs https://airflow.apache.org/docs/apache-airflow-providers-oracle/stable/connections/oracle.html are slightly misleading I think (They do not mention that service_name is passed as service_name extra.
   
   However I think I am perfectly fine with using schema as service_name in case the latter is not present. That makes sense and makes it consistent with other DBAPIHooks (for example MySQL https://airflow.apache.org/docs/apache-airflow-providers-mysql/stable/connections/mysql.html) . Would you mind also updating the docs for it ? 
   
   And yeah. That would indeed be nicer URL in many cases:
   
   `host:port/service` 
   
   rather than 
   
   `host:port?__extra__service_name=service`
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org