You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by al...@apache.org on 2020/05/12 00:15:17 UTC
[beam] 01/01: Clarify pubsub IO comment
This is an automated email from the ASF dual-hosted git repository.
altay pushed a commit to branch aaltay-patch-2
in repository https://gitbox.apache.org/repos/asf/beam.git
commit ddbfab5ab948349f2d60763d038f7d79882f5ecb
Author: Ahmet Altay <aa...@gmail.com>
AuthorDate: Mon May 11 17:15:04 2020 -0700
Clarify pubsub IO comment
Updated based on the information from https://github.com/apache/beam/blob/cad0333d6e27a9646fb70289bc8d2dde770b55af/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubClient.java#L86
---
.../src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubIO.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubIO.java b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubIO.java
index ee36fd2..66d94eb 100644
--- a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubIO.java
+++ b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubIO.java
@@ -752,8 +752,8 @@ public class PubsubIO {
* (i.e., time units smaller than milliseconds) will be ignored.
* </ul>
*
- * <p>If {@code timestampAttribute} is not provided, the system will generate record timestamps
- * the first time it sees each record. All windowing will be done relative to these timestamps.
+ * <p>If {@code timestampAttribute} is not provided, the timestamp will be taken from the
+ * Pubsub publish timestamp. All windowing will be done relative to these timestamps.
*
* <p>By default, windows are emitted based on an estimate of when this source is likely done
* producing data for a given timestamp (referred to as the Watermark; see {@link