[GitHub] [tvm] junrushao1994 commented on a diff in pull request #11576: [MetaSchedule] exposed method: TuneContextNodeInitialize

[GitBox <gi...@apache.org>]

junrushao1994 commented on code in PR #11576:
URL: https://github.com/apache/tvm/pull/11576#discussion_r889624911


##########
src/meta_schedule/tune_context.cc:
##########
@@ -89,6 +89,8 @@ TVM_REGISTER_GLOBAL("meta_schedule.TuneContext")
     });
 
 TVM_REGISTER_GLOBAL("meta_schedule._SHash2Hex").set_body_typed(SHash2Hex);
+TVM_REGISTER_GLOBAL("meta_schedule.TuneContextNodeInitialize")
+    .set_body_method<TuneContext>(&TuneContextNode::Initialize);

Review Comment:
   Following the naming convention, let's remove "Node" and use `TuneContext` directly :-)
   
   ```suggestion
   TVM_REGISTER_GLOBAL("meta_schedule.TuneContextInitialize")
       .set_body_method<TuneContext>(&TuneContextNode::Initialize);
   ```



##########
python/tvm/meta_schedule/tune_context.py:
##########
@@ -129,3 +129,4 @@ def __init__(
             rand_state,
             num_threads,
         )
+        _ffi_api.TuneContextNodeInitialize(self)

Review Comment:
   To be consistent on the C++ side, shall we have a separate method like below instead of initializing everything by default?
   
   ```python
   def initialize(self): ...
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org