You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "laglangyue (via GitHub)" <gi...@apache.org> on 2023/12/15 09:47:37 UTC
[PR] [pekko-connectors-sample-jdbc-to-elasticsearch] Migate akka to Pekko-connectors [incubator-pekko-connectors-samples]
laglangyue opened a new pull request, #13:
URL: https://github.com/apache/incubator-pekko-connectors-samples/pull/13
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] [jdbc-to-elasticsearch] Migrate akka dependencies to pekko [incubator-pekko-connectors-samples]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #13:
URL: https://github.com/apache/incubator-pekko-connectors-samples/pull/13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] [WIP][pekko-connectors-sample-jdbc-to-elasticsearch] Migate akka to Pekko-connectors [incubator-pekko-connectors-samples]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #13:
URL: https://github.com/apache/incubator-pekko-connectors-samples/pull/13#discussion_r1427883728
##########
pekko-connectors-sample-jdbc-to-elasticsearch/step_001_complete/src/main/java/samples/javadsl/Main.java:
##########
@@ -1,31 +1,39 @@
/*
- * Copyright (C) 2016-2019 Lightbend Inc. <http://www.lightbend.com>
Review Comment:
Revert all license changes. We need to keep the Lightbend headers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] [WIP][pekko-connectors-sample-jdbc-to-elasticsearch] Migate akka to Pekko-connectors [incubator-pekko-connectors-samples]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on code in PR #13:
URL: https://github.com/apache/incubator-pekko-connectors-samples/pull/13#discussion_r1428717205
##########
pekko-connectors-sample-jdbc-to-elasticsearch/step_001_complete/src/main/java/samples/javadsl/Main.java:
##########
@@ -1,31 +1,39 @@
/*
- * Copyright (C) 2016-2019 Lightbend Inc. <http://www.lightbend.com>
Review Comment:
I have removed apache license headers keep it. Friendly question: Why not add the Apache license header?
##########
pekko-connectors-sample-jdbc-to-elasticsearch/step_001_complete/src/main/java/samples/javadsl/Main.java:
##########
@@ -1,31 +1,39 @@
/*
- * Copyright (C) 2016-2019 Lightbend Inc. <http://www.lightbend.com>
Review Comment:
I have removed apache license headers and keep it. Friendly question: Why not add the Apache license header?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] [WIP][pekko-connectors-sample-jdbc-to-elasticsearch] Migate akka to Pekko-connectors [incubator-pekko-connectors-samples]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on code in PR #13:
URL: https://github.com/apache/incubator-pekko-connectors-samples/pull/13#discussion_r1428712778
##########
pekko-connectors-sample-jdbc-to-elasticsearch/step_001_complete/src/main/java/samples/javadsl/Main.java:
##########
@@ -1,31 +1,39 @@
/*
- * Copyright (C) 2016-2019 Lightbend Inc. <http://www.lightbend.com>
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] [jdbc-to-elasticsearch] Migrate akka dependencies to pekko [incubator-pekko-connectors-samples]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #13:
URL: https://github.com/apache/incubator-pekko-connectors-samples/pull/13#discussion_r1428747689
##########
pekko-connectors-sample-jdbc-to-elasticsearch/step_001_complete/src/main/java/samples/javadsl/Main.java:
##########
@@ -1,31 +1,39 @@
/*
- * Copyright (C) 2016-2019 Lightbend Inc. <http://www.lightbend.com>
Review Comment:
When a source file already has a license header, you normally just keep it. It's a big legal mine field and it's been one of the most complicated aspects of getting Pekko up and running. I am busy this weekend and don't have time to study the licenses. I will look at them next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] [WIP][pekko-connectors-sample-jdbc-to-elasticsearch] Migate akka to Pekko-connectors [incubator-pekko-connectors-samples]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #13:
URL: https://github.com/apache/incubator-pekko-connectors-samples/pull/13#discussion_r1427882278
##########
pekko-connectors-sample-jdbc-to-elasticsearch/project/Dependencies.scala:
##########
@@ -1,27 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * license agreements; and to You under the Apache License, version 2.0:
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * This file is part of the Apache Pekko project, which was derived from Akka.
+ */
+
import sbt._
object Dependencies {
val scalaVer = "2.13.8"
- // #deps
- val AkkaVersion = "2.6.19"
- val AlpakkaVersion = "4.0.0"
+
+ val pekkoVersion = "1.0.1"
+
+ val pekkoConnectorVersion = "1.0.1+12-db689989-SNAPSHOT"
Review Comment:
Use the 1.0.2 release not a snaphot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] [WIP][pekko-connectors-sample-jdbc-to-elasticsearch] Migate akka to Pekko-connectors [incubator-pekko-connectors-samples]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on PR #13:
URL: https://github.com/apache/incubator-pekko-connectors-samples/pull/13#issuecomment-1857696801
[info] * org.apache.pekko:pekko-stream_2.13:1.0.2 is selected over {1.0.1, 1.0.1}
[info] +- org.apache.pekko:step_001_complete_2.13:1.0.1 (depends on 1.0.2)
[info] +- org.apache.pekko:pekko-connectors-slick_2.13:1.0.1+12-db689989-SNAPSHOT (depends on 1.0.2)
[info] +- org.apache.pekko:pekko-connectors-elasticsearch_2.13:1.0.1+12-db689989-SNAPSHOT (depends on 1.0.2)
which version can be used for pekko-connectors of pekko-1.0.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] [WIP][pekko-connectors-sample-jdbc-to-elasticsearch] Migate akka to Pekko-connectors [incubator-pekko-connectors-samples]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on code in PR #13:
URL: https://github.com/apache/incubator-pekko-connectors-samples/pull/13#discussion_r1428713753
##########
pekko-connectors-sample-jdbc-to-elasticsearch/project/Dependencies.scala:
##########
@@ -1,27 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * license agreements; and to You under the Apache License, version 2.0:
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * This file is part of the Apache Pekko project, which was derived from Akka.
+ */
+
import sbt._
object Dependencies {
val scalaVer = "2.13.8"
- // #deps
- val AkkaVersion = "2.6.19"
- val AlpakkaVersion = "4.0.0"
+
+ val pekkoVersion = "1.0.1"
+
+ val pekkoConnectorVersion = "1.0.1+12-db689989-SNAPSHOT"
Review Comment:
I did not find pekko connectors 1.0.2 in the Maven repository, so I used snapshot to test this sample locally and learn pekko streams. After the official release 1.0.2, I will change the versions of pekko and pekko connectors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] [WIP][pekko-connectors-sample-jdbc-to-elasticsearch] Migate akka to Pekko-connectors [incubator-pekko-connectors-samples]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on code in PR #13:
URL: https://github.com/apache/incubator-pekko-connectors-samples/pull/13#discussion_r1428717205
##########
pekko-connectors-sample-jdbc-to-elasticsearch/step_001_complete/src/main/java/samples/javadsl/Main.java:
##########
@@ -1,31 +1,39 @@
/*
- * Copyright (C) 2016-2019 Lightbend Inc. <http://www.lightbend.com>
Review Comment:
I have removed apache license headers and keep the Lightbend headers. Friendly question: Why not add the Apache license header?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] [jdbc-to-elasticsearch] Migrate akka dependencies to pekko [incubator-pekko-connectors-samples]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #13:
URL: https://github.com/apache/incubator-pekko-connectors-samples/pull/13#issuecomment-1858777975
I pushed a few changes but I'm going to ask that we stop working on this for a few days.
This repo seems to require https://scalacenter.github.io/course-management-tools/docs/install and I've never used that. I need to find time to work out how to use and see if I can get the docs built for the samples. There isn't much point in updating the samples if we can't get the docs published.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org