You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Zameer Manji <zm...@apache.org> on 2016/03/03 21:16:02 UTC

Review Request 44354: Show principal in auth failure messaage.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44354/
-----------------------------------------------------------

Review request for Aurora and Stephan Erb.


Bugs: AURORA-1628
    https://issues.apache.org/jira/browse/AURORA-1628


Repository: aurora


Description
-------

Show principal in auth failure messaage.


Diffs
-----

  src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java 3043dfacfe824551b15595a070a1a4fdb7967d3a 

Diff: https://reviews.apache.org/r/44354/diff/


Testing
-------


Thanks,

Zameer Manji

Re: Review Request 44354: Show principal in auth failure messaage.

Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44354/#review121941
-----------------------------------------------------------



@ReviewBot retry

- Zameer Manji


On March 3, 2016, 12:16 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44354/
> -----------------------------------------------------------
> 
> (Updated March 3, 2016, 12:16 p.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Bugs: AURORA-1628
>     https://issues.apache.org/jira/browse/AURORA-1628
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Show principal in auth failure messaage.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java 3043dfacfe824551b15595a070a1a4fdb7967d3a 
> 
> Diff: https://reviews.apache.org/r/44354/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 44354: Show principal in auth failure messaage.

Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44354/#review121984
-----------------------------------------------------------



I think the test failure is because subject is a mock, so you need to add an expectation to the test for the `subject.getPrincipal()` call you added to generate the response entity?

- Joshua Cohen


On March 3, 2016, 8:16 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44354/
> -----------------------------------------------------------
> 
> (Updated March 3, 2016, 8:16 p.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Bugs: AURORA-1628
>     https://issues.apache.org/jira/browse/AURORA-1628
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Show principal in auth failure messaage.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java 3043dfacfe824551b15595a070a1a4fdb7967d3a 
> 
> Diff: https://reviews.apache.org/r/44354/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 44354: Show principal in auth failure messaage.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44354/#review121931
-----------------------------------------------------------



Master (98a2bc1) is red with this patch.
  ./build-support/jenkins/build.sh

:licenseJmh UP-TO-DATE
:licenseMain UP-TO-DATE
:licenseTest UP-TO-DATE
:license UP-TO-DATE
:pmdJmh
:pmdMain
:pmdTest
:test

org.apache.aurora.scheduler.http.api.security.ShiroAuthorizingParamInterceptorTest > testKillTasksWithTargetedPermission FAILED
    java.lang.AssertionError at ShiroAuthorizingParamInterceptorTest.java:153
I0303 20:23:09.577 [ShutdownHook, SchedulerMain:99] Stopping scheduler services. 
I0303 20:23:09.769 [RedirectMonitor STARTING-SendThread(localhost:34478), ClientCnxn$SendThread:975] Opening socket connection to server localhost/127.0.0.1:34478. Will not attempt to authenticate using SASL (unknown error) 
W0303 20:23:09.771 [RedirectMonitor STARTING-SendThread(localhost:34478), ClientCnxn$SendThread:1102] Session 0x1533e2537af0000 for server null, unexpected error, closing socket connection and attempting reconnect java.net.ConnectException: Connection refused
	at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) ~[na:1.8.0_45]
	at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717) ~[na:1.8.0_45]
	at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:361) ~[zookeeper-3.4.6.jar:3.4.6-1569965]
	at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1081) ~[zookeeper-3.4.6.jar:3.4.6-1569965]


937 tests completed, 1 failed, 2 skipped
:test FAILED
:jacocoTestReport
Coverage report generated: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html
:analyzeReport
Instruction coverage is 0.889190696772003, but must be greater than 0.89
Branch coverage is 0.8211425520555259, but must be greater than 0.835

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':test'.
> There were failing tests. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/tests/index.html

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 10 mins 24.721 secs


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On March 3, 2016, 8:16 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44354/
> -----------------------------------------------------------
> 
> (Updated March 3, 2016, 8:16 p.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Bugs: AURORA-1628
>     https://issues.apache.org/jira/browse/AURORA-1628
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Show principal in auth failure messaage.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java 3043dfacfe824551b15595a070a1a4fdb7967d3a 
> 
> Diff: https://reviews.apache.org/r/44354/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 44354: Show principal in auth failure messaage.

Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44354/#review121934
-----------------------------------------------------------


Ship it!




Ship It!

- Stephan Erb


On März 3, 2016, 9:16 nachm., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44354/
> -----------------------------------------------------------
> 
> (Updated März 3, 2016, 9:16 nachm.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Bugs: AURORA-1628
>     https://issues.apache.org/jira/browse/AURORA-1628
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Show principal in auth failure messaage.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java 3043dfacfe824551b15595a070a1a4fdb7967d3a 
> 
> Diff: https://reviews.apache.org/r/44354/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 44354: Show principal in auth failure messaage.

Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44354/#review121935
-----------------------------------------------------------



Is the build failure related? Code change itself looks fine (thus the ship it above).

- Stephan Erb


On März 3, 2016, 9:16 nachm., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44354/
> -----------------------------------------------------------
> 
> (Updated März 3, 2016, 9:16 nachm.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Bugs: AURORA-1628
>     https://issues.apache.org/jira/browse/AURORA-1628
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Show principal in auth failure messaage.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java 3043dfacfe824551b15595a070a1a4fdb7967d3a 
> 
> Diff: https://reviews.apache.org/r/44354/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 44354: Show principal in auth failure messaage.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44354/#review121943
-----------------------------------------------------------



Master (98a2bc1) is red with this patch.
  ./build-support/jenkins/build.sh


:processTestResources
:testClasses
:checkstyleTest
:findbugsJmh
:findbugsMain
:findbugsTest
:licenseJmh UP-TO-DATE
:licenseMain UP-TO-DATE
:licenseTest UP-TO-DATE
:license UP-TO-DATE
:pmdJmh
:pmdMain
:pmdTest
:test

org.apache.aurora.scheduler.http.api.security.ShiroAuthorizingParamInterceptorTest > testKillTasksWithTargetedPermission FAILED
    java.lang.AssertionError at ShiroAuthorizingParamInterceptorTest.java:153
I0303 21:43:46.663 [ShutdownHook, SchedulerMain:99] Stopping scheduler services. 

937 tests completed, 1 failed, 2 skipped
:test FAILED
:jacocoTestReport
Coverage report generated: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html
:analyzeReport
Instruction coverage is 0.8892392016103606, but must be greater than 0.89
Branch coverage is 0.8216764548852109, but must be greater than 0.835

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':test'.
> There were failing tests. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/tests/index.html

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 10 mins 48.991 secs


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On March 3, 2016, 8:16 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44354/
> -----------------------------------------------------------
> 
> (Updated March 3, 2016, 8:16 p.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Bugs: AURORA-1628
>     https://issues.apache.org/jira/browse/AURORA-1628
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Show principal in auth failure messaage.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java 3043dfacfe824551b15595a070a1a4fdb7967d3a 
> 
> Diff: https://reviews.apache.org/r/44354/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 44354: Show principal in auth failure messaage.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44354/#review122118
-----------------------------------------------------------


Ship it!




Master (a4e7b3a) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On March 4, 2016, 6:03 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44354/
> -----------------------------------------------------------
> 
> (Updated March 4, 2016, 6:03 p.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Bugs: AURORA-1628
>     https://issues.apache.org/jira/browse/AURORA-1628
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Show principal in auth failure messaage.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java 3043dfacfe824551b15595a070a1a4fdb7967d3a 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java b5b405bdff189120a0e8e2beb1159571321d5b96 
> 
> Diff: https://reviews.apache.org/r/44354/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 44354: Show principal in auth failure messaage.

Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44354/#review122119
-----------------------------------------------------------


Ship it!




Ship It!

- Joshua Cohen


On March 4, 2016, 6:03 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44354/
> -----------------------------------------------------------
> 
> (Updated March 4, 2016, 6:03 p.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Bugs: AURORA-1628
>     https://issues.apache.org/jira/browse/AURORA-1628
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Show principal in auth failure messaage.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java 3043dfacfe824551b15595a070a1a4fdb7967d3a 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java b5b405bdff189120a0e8e2beb1159571321d5b96 
> 
> Diff: https://reviews.apache.org/r/44354/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 44354: Show principal in auth failure messaage.

Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44354/
-----------------------------------------------------------

(Updated March 4, 2016, 10:03 a.m.)


Review request for Aurora and Stephan Erb.


Changes
-------

Fix test.


Bugs: AURORA-1628
    https://issues.apache.org/jira/browse/AURORA-1628


Repository: aurora


Description
-------

Show principal in auth failure messaage.


Diffs (updated)
-----

  src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java 3043dfacfe824551b15595a070a1a4fdb7967d3a 
  src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java b5b405bdff189120a0e8e2beb1159571321d5b96 

Diff: https://reviews.apache.org/r/44354/diff/


Testing
-------


Thanks,

Zameer Manji