You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/14 00:28:52 UTC
[GitHub] [arrow] kou commented on a change in pull request #7171: ARROW-8790: [C++][CI] Enable arrow-flight-test on s390x
kou commented on a change in pull request #7171:
URL: https://github.com/apache/arrow/pull/7171#discussion_r424804727
##########
File path: .travis.yml
##########
@@ -92,6 +95,9 @@ script:
-e ARROW_PARQUET=${ARROW_PARQUET:-ON} \
-e PARQUET_BUILD_EXAMPLES=${PARQUET_BUILD_EXAMPLES:-ON} \
-e PARQUET_BUILD_EXECUTABLES=${PARQUET_BUILD_EXECUTABLES:-ON} \
+ -e cares_SOURCE=${cares_SOURCE:-AUTO} \
+ -e gRPC_SOURCE=${gRPC_SOURCE:-AUTO} \
+ -e Protobuf_SOURCE=${Protobuf_SOURCE:-AUTO} \
Review comment:
Could you use empty string (`${XXX:-}`) instead of `AUTO` as the default value?
Because empty string is the default value in `ci/script/cpp_build.sh`.
##########
File path: .travis.yml
##########
@@ -92,6 +95,9 @@ script:
-e ARROW_PARQUET=${ARROW_PARQUET:-ON} \
-e PARQUET_BUILD_EXAMPLES=${PARQUET_BUILD_EXAMPLES:-ON} \
-e PARQUET_BUILD_EXECUTABLES=${PARQUET_BUILD_EXECUTABLES:-ON} \
+ -e cares_SOURCE=${cares_SOURCE:-AUTO} \
+ -e gRPC_SOURCE=${gRPC_SOURCE:-AUTO} \
+ -e Protobuf_SOURCE=${Protobuf_SOURCE:-AUTO} \
Review comment:
Could you sort this list alphabetically?
##########
File path: .travis.yml
##########
@@ -47,11 +47,14 @@ jobs:
env:
ARCH: s390x
ARROW_CI_MODULES: "CPP"
- ARROW_FLIGHT: "OFF"
+ ARROW_FLIGHT: "ON"
ARROW_GANDIVA: "OFF"
ARROW_PARQUET: "OFF"
PARQUET_BUILD_EXAMPLES: "OFF"
PARQUET_BUILD_EXECUTABLES: "OFF"
+ cares_SOURCE: "BUNDLED"
+ Protobuf_SOURCE: "BUNDLED"
+ gRPC_SOURCE: "BUNDLED"
Review comment:
Could you sort `env` list alphabetically?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org