You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2022/01/21 11:57:46 UTC
[GitHub] [hadoop] virajjasani commented on a change in pull request #3891: HADOOP-18082.Add debug log when RPC#Reader gets a Call.
virajjasani commented on a change in pull request #3891:
URL: https://github.com/apache/hadoop/pull/3891#discussion_r789598239
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
##########
@@ -3046,6 +3046,8 @@ private void internalQueueCall(Call call, boolean blocking)
} else {
callQueue.add(call);
}
+
+ LOG.debug("{} has entered the CallQueue and is waiting to be processed.", call);
Review comment:
The change to add a DEBUG log seems good, but how about this line instead?
`LOG.debug("Call has entered the CallQueue and is waiting to be processed. Call details: {}", call);`
Usually we tend to read object's string presentation at the end to not mix up with the log statement, e.g RpcCall's toString() has word "from" and perhaps it becomes bit difficult to read the whole statement at the first sight, but if put at the end of the statement, we know that now we are only looking at RpcCall details:
```
@Override
public String toString() {
return super.toString() + " " + rpcRequest + " from " + connection;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org