[GitHub] [spark] MaxGekk commented on pull request #29363: [SPARK-32546][SQL] Get table names directly from Hive tables

[GitBox <gi...@apache.org>]

MaxGekk commented on pull request #29363:
URL: https://github.com/apache/spark/pull/29363#issuecomment-669371973


   > What do you mean by the following, @MaxGekk ? The existing test suite already has been passing without this PR.
   
   @dongjoon-hyun I mean that all modified lines by me are covered by the tests. Could you image a function which should increase an integer by one:
   ```scala
   def plusOne(i: Int): Int = {
     downloadPage("http://www.blablabla.com")
     i + 1
   }
   ```
   If we remove unnecessary code `downloadPage` which can fail sometimes, the tests for main functionality will still pass. I don't see any reasons to check function behaviour when `http://www.blablabla.com` is not available.
   
   The same in our situation `listTablesByType()` instantiates row SerDes via reflection even it is not needed to get the list of table names.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org