You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/02/26 22:43:13 UTC
[GitHub] piiswrong commented on a change in pull request #9877: Better even_split=False support in gluon.split_data()
piiswrong commented on a change in pull request #9877: Better even_split=False support in gluon.split_data()
URL: https://github.com/apache/incubator-mxnet/pull/9877#discussion_r170760306
##########
File path: python/mxnet/gluon/utils.py
##########
@@ -56,13 +56,10 @@ def split_data(data, num_slice, batch_axis=0, even_split=True):
Returns
-------
list of NDArray
- Return value is a list even if `num_slice` is 1.
+ Return value is a list even if `num_slice` is 1. When `even_split`
+ is `False` this may be shorter than `num_slice`.
Review comment:
Is this a good idea?
when used for multi-gpu, this would cause some gpus to not get data, then gradient will be stale during update
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services