You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pulsar.apache.org by Jia Zhai <zh...@apache.org> on 2020/05/21 06:50:26 UTC

[Discuss] Disable "Require branches to be up-to-date before merging" for github

Hi Guys,

Recently we enabled feature "Require branches to be up-to-date before
merging" in github by help from ASF infra team, as this has been discussed
several times to protect merge conflict.

But seems it is not worked as expected, some of the PRs does not have a
button "update branch" when PR branch out of date happens. e.g. [PR 6801](
https://github.com/apache/pulsar/pull/6801).
So would like to discuss to disable this feature.

Thanks and regards.

Re: [Discuss] Disable "Require branches to be up-to-date before merging" for github

Posted by Jia Zhai <zh...@apache.org>.

Would like to do a quick summary for this discussion:

3 binding +1 votes, 0 -1 votes.

3 +1 bindings are from:
PengHui Li
Sijie Guo
Jia Zhai


On Thu, May 21, 2020 at 6:04 PM Jia Zhai <zh...@gmail.com> wrote:

> Thanks. Add my own +1.
>
> Best Regards.
>
>
> Jia Zhai
>
> Beijing, China
>
> Mobile: +86 15810491983
>
>
>
>
> On Thu, May 21, 2020 at 5:46 PM PengHui Li <co...@gmail.com>
> wrote:
>
>> +1
>> On May 21, 2020, 3:31 PM +0800, Sijie Guo <gu...@gmail.com>, wrote:
>> > +1
>> >
>> > On Wed, May 20, 2020 at 11:51 PM Jia Zhai <zh...@apache.org> wrote:
>> >
>> > > Hi Guys,
>> > >
>> > > Recently we enabled feature "Require branches to be up-to-date before
>> > > merging" in github by help from ASF infra team, as this has been
>> discussed
>> > > several times to protect merge conflict.
>> > >
>> > > But seems it is not worked as expected, some of the PRs does not have
>> a
>> > > button "update branch" when PR branch out of date happens. e.g. [PR
>> 6801](
>> > > https://github.com/apache/pulsar/pull/6801).
>> > > So would like to discuss to disable this feature.
>> > >
>> > > Thanks and regards.
>> > >
>>
>

Re: [Discuss] Disable "Require branches to be up-to-date before merging" for github

Posted by Jia Zhai <zh...@gmail.com>.

Thanks. Add my own +1.

Best Regards.


Jia Zhai

Beijing, China

Mobile: +86 15810491983




On Thu, May 21, 2020 at 5:46 PM PengHui Li <co...@gmail.com> wrote:

> +1
> On May 21, 2020, 3:31 PM +0800, Sijie Guo <gu...@gmail.com>, wrote:
> > +1
> >
> > On Wed, May 20, 2020 at 11:51 PM Jia Zhai <zh...@apache.org> wrote:
> >
> > > Hi Guys,
> > >
> > > Recently we enabled feature "Require branches to be up-to-date before
> > > merging" in github by help from ASF infra team, as this has been
> discussed
> > > several times to protect merge conflict.
> > >
> > > But seems it is not worked as expected, some of the PRs does not have a
> > > button "update branch" when PR branch out of date happens. e.g. [PR
> 6801](
> > > https://github.com/apache/pulsar/pull/6801).
> > > So would like to discuss to disable this feature.
> > >
> > > Thanks and regards.
> > >
>

Re: [Discuss] Disable "Require branches to be up-to-date before merging" for github

Posted by PengHui Li <co...@gmail.com>.

+1
On May 21, 2020, 3:31 PM +0800, Sijie Guo <gu...@gmail.com>, wrote:
> +1
>
> On Wed, May 20, 2020 at 11:51 PM Jia Zhai <zh...@apache.org> wrote:
>
> > Hi Guys,
> >
> > Recently we enabled feature "Require branches to be up-to-date before
> > merging" in github by help from ASF infra team, as this has been discussed
> > several times to protect merge conflict.
> >
> > But seems it is not worked as expected, some of the PRs does not have a
> > button "update branch" when PR branch out of date happens. e.g. [PR 6801](
> > https://github.com/apache/pulsar/pull/6801).
> > So would like to discuss to disable this feature.
> >
> > Thanks and regards.
> >

Re: [Discuss] Disable "Require branches to be up-to-date before merging" for github

Posted by Sijie Guo <gu...@gmail.com>.

+1

On Wed, May 20, 2020 at 11:51 PM Jia Zhai <zh...@apache.org> wrote:

> Hi Guys,
>
> Recently we enabled feature "Require branches to be up-to-date before
> merging" in github by help from ASF infra team, as this has been discussed
> several times to protect merge conflict.
>
> But seems it is not worked as expected, some of the PRs does not have a
> button "update branch" when PR branch out of date happens. e.g. [PR 6801](
> https://github.com/apache/pulsar/pull/6801).
> So would like to discuss to disable this feature.
>
> Thanks and regards.
>