You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Ted Steen (JIRA)" <de...@tapestry.apache.org> on 2007/11/14 20:43:43 UTC
[jira] Created: (TAPESTRY-1911) Context unnecessarley decoded in
PageRenderDispatcher and ComponentActionDispatcher
Context unnecessarley decoded in PageRenderDispatcher and ComponentActionDispatcher
-----------------------------------------------------------------------------------
Key: TAPESTRY-1911
URL: https://issues.apache.org/jira/browse/TAPESTRY-1911
Project: Tapestry
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.0.6, 5.0.5, 5.0.4, 5.0.3
Reporter: Ted Steen
Fix For: 5.0.7
In PageRenderDispatcher, these two lines will result in a TapestryInternalUtils.urlDecode() on
the context.
069 String[] context = atEnd ? new String[0] :
convertActivationContext(path
070 .substring(nextslashx + 1));
It seems that this is already done by the servlet, so the decoding is
done twice, and results in malformed contexts.
This also applies to the ComponentActionDispatcher
Look here for previous discussions,
http://mail-archives.apache.org/mod_mbox/tapestry-users/200706.mbox/%3C1182418365.3432.27.camel@localhost%3E
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Closed: (TAPESTRY-1911) Context unnecessarley decoded in
PageRenderDispatcher and ComponentActionDispatcher
Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAPESTRY-1911.
------------------------------------------
Resolution: Duplicate
Duplicate of TAPESTRY-1988.
> Context unnecessarley decoded in PageRenderDispatcher and ComponentActionDispatcher
> -----------------------------------------------------------------------------------
>
> Key: TAPESTRY-1911
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1911
> Project: Tapestry
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.0.3, 5.0.4, 5.0.5, 5.0.6
> Reporter: Ted Steen
> Assignee: Howard M. Lewis Ship
>
> In PageRenderDispatcher, these two lines will result in a TapestryInternalUtils.urlDecode() on
> the context.
> 069 String[] context = atEnd ? new String[0] :
> convertActivationContext(path
> 070 .substring(nextslashx + 1));
> It seems that this is already done by the servlet, so the decoding is
> done twice, and results in malformed contexts.
> This also applies to the ComponentActionDispatcher
> Look here for previous discussions,
> http://mail-archives.apache.org/mod_mbox/tapestry-users/200706.mbox/%3C1182418365.3432.27.camel@localhost%3E
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Reopened: (TAPESTRY-1911) Context unnecessarley decoded in
PageRenderDispatcher and ComponentActionDispatcher
Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship reopened TAPESTRY-1911:
--------------------------------------------
Someone else did better research than me ...
> Context unnecessarley decoded in PageRenderDispatcher and ComponentActionDispatcher
> -----------------------------------------------------------------------------------
>
> Key: TAPESTRY-1911
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1911
> Project: Tapestry
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.0.3, 5.0.4, 5.0.5, 5.0.6
> Reporter: Ted Steen
> Assignee: Howard M. Lewis Ship
>
> In PageRenderDispatcher, these two lines will result in a TapestryInternalUtils.urlDecode() on
> the context.
> 069 String[] context = atEnd ? new String[0] :
> convertActivationContext(path
> 070 .substring(nextslashx + 1));
> It seems that this is already done by the servlet, so the decoding is
> done twice, and results in malformed contexts.
> This also applies to the ComponentActionDispatcher
> Look here for previous discussions,
> http://mail-archives.apache.org/mod_mbox/tapestry-users/200706.mbox/%3C1182418365.3432.27.camel@localhost%3E
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Updated: (TAPESTRY-1911) Context unnecessarley decoded in
PageRenderDispatcher and ComponentActionDispatcher
Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship updated TAPESTRY-1911:
-------------------------------------------
Fix Version/s: (was: 5.0.7)
> Context unnecessarley decoded in PageRenderDispatcher and ComponentActionDispatcher
> -----------------------------------------------------------------------------------
>
> Key: TAPESTRY-1911
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1911
> Project: Tapestry
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.0.3, 5.0.4, 5.0.5, 5.0.6
> Reporter: Ted Steen
> Assignee: Howard M. Lewis Ship
>
> In PageRenderDispatcher, these two lines will result in a TapestryInternalUtils.urlDecode() on
> the context.
> 069 String[] context = atEnd ? new String[0] :
> convertActivationContext(path
> 070 .substring(nextslashx + 1));
> It seems that this is already done by the servlet, so the decoding is
> done twice, and results in malformed contexts.
> This also applies to the ComponentActionDispatcher
> Look here for previous discussions,
> http://mail-archives.apache.org/mod_mbox/tapestry-users/200706.mbox/%3C1182418365.3432.27.camel@localhost%3E
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Closed: (TAPESTRY-1911) Context unnecessarley decoded in
PageRenderDispatcher and ComponentActionDispatcher
Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAPESTRY-1911.
------------------------------------------
Resolution: Invalid
Assignee: Howard M. Lewis Ship
My investigation has shown that this is necessary, that the servlet container does not perform the decoding automatically. I just hope this isn't a Tomcat vs. Jetty issue!
> Context unnecessarley decoded in PageRenderDispatcher and ComponentActionDispatcher
> -----------------------------------------------------------------------------------
>
> Key: TAPESTRY-1911
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1911
> Project: Tapestry
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.0.3, 5.0.4, 5.0.5, 5.0.6
> Reporter: Ted Steen
> Assignee: Howard M. Lewis Ship
> Fix For: 5.0.7
>
>
> In PageRenderDispatcher, these two lines will result in a TapestryInternalUtils.urlDecode() on
> the context.
> 069 String[] context = atEnd ? new String[0] :
> convertActivationContext(path
> 070 .substring(nextslashx + 1));
> It seems that this is already done by the servlet, so the decoding is
> done twice, and results in malformed contexts.
> This also applies to the ComponentActionDispatcher
> Look here for previous discussions,
> http://mail-archives.apache.org/mod_mbox/tapestry-users/200706.mbox/%3C1182418365.3432.27.camel@localhost%3E
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-1911) Context unnecessarley decoded in
PageRenderDispatcher and ComponentActionDispatcher
Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543767 ]
Howard M. Lewis Ship commented on TAPESTRY-1911:
------------------------------------------------
At first I put this down to a misunderstanding on my part of the servlet API.
However, when I remove the explicit URL decoding logic, existing tests break. Specifically, tests for cases where there are URL encoded characters inside the context. These are Selenium tests, which means that the full servlet API stack from Jetty, unchanged, is in charge ... and that brings into question the thought that it is servlet containers job to URL decode.
> Context unnecessarley decoded in PageRenderDispatcher and ComponentActionDispatcher
> -----------------------------------------------------------------------------------
>
> Key: TAPESTRY-1911
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1911
> Project: Tapestry
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.0.3, 5.0.4, 5.0.5, 5.0.6
> Reporter: Ted Steen
> Fix For: 5.0.7
>
>
> In PageRenderDispatcher, these two lines will result in a TapestryInternalUtils.urlDecode() on
> the context.
> 069 String[] context = atEnd ? new String[0] :
> convertActivationContext(path
> 070 .substring(nextslashx + 1));
> It seems that this is already done by the servlet, so the decoding is
> done twice, and results in malformed contexts.
> This also applies to the ComponentActionDispatcher
> Look here for previous discussions,
> http://mail-archives.apache.org/mod_mbox/tapestry-users/200706.mbox/%3C1182418365.3432.27.camel@localhost%3E
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org