You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/19 21:07:28 UTC

[GitHub] [spark] srowen commented on pull request #35573: [WIP] [SPARK-38060] [SQL] Respect allowNonNumericNumbers when parsing quoted NaN and Infinity values in JSON reader

srowen commented on pull request #35573:
URL: https://github.com/apache/spark/pull/35573#issuecomment-1046102850


   Dumb questions as I just don't know this code path -- would we parse `"1.0"` as a number or reject it for being a string? and you're saying that Jackson would parse `"NaN"` as NaN and not a string? It feels weird to parse strings that aren't even numbers as numbers, even when the option to do so is set, but if that is consistent with other behavior I could see it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org