You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@sentry.apache.org by "Alexander Kolbasov (JIRA)" <ji...@apache.org> on 2017/05/24 23:18:04 UTC

[jira] [Created] (SENTRY-1783) alterSentryRoleGrantPrivilegeCore does more persistence work than required

Alexander Kolbasov created SENTRY-1783:
------------------------------------------

             Summary: alterSentryRoleGrantPrivilegeCore does more persistence work than required
                 Key: SENTRY-1783
                 URL: https://issues.apache.org/jira/browse/SENTRY-1783
             Project: Sentry
          Issue Type: Bug
          Components: sentrystore
    Affects Versions: 1.8.0, sentry-ha-redesign
            Reporter: Alexander Kolbasov
            Assignee: Alexander Kolbasov


In the end of alterSentryRoleGrantPrivilegeCore() there is the following code:

{code}
mPrivilege.appendRole(mRole);
pm.makePersistent(mRole);
pm.makePersistent(mPrivilege);
{code}

I think the second makePersistent call isn't needed and can only cause troubles (extra potential for deadlock). When the role is made persistent, the associated privilege should be updated as well.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)