[GitHub] [fineract] Yann-J commented on a change in pull request #1623: feat: Helm chart

[GitBox <gi...@apache.org>]

Yann-J commented on a change in pull request #1623:
URL: https://github.com/apache/fineract/pull/1623#discussion_r595285462



##########
File path: helm/fineract/values.yaml
##########
@@ -0,0 +1,83 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# TODO: add option to install ActiveMQ?
+
+fineractServer:
+  replicas: 1
+  image:
+    name: apache/fineract
+    tag: latest
+  # key/value pairs to pass as environment variables to the backend pods
+  extraEnv:
+    DRIVERCLASS_NAME: org.drizzle.jdbc.DrizzleDriver
+    PROTOCOL: jdbc
+    SUB_PROTOCOL: mysql:thin
+    fineract_tenants_driver: org.drizzle.jdbc.DrizzleDriver
+    FINERACT_DEFAULT_TENANTDB_PORT: "3306"
+  # sensitive key/value pairs to pass as environment variables to the backend pods as secrets
+  extraSecretEnv: {}
+
+fineractUI:
+  replicas: 1
+  image:
+    name: openmf/community-app
+    tag: latest
+
+# Globals will be available to subcharts
+global:
+  db:
+    tenantsDb: fineract_tenants
+    defaultDb: fineract_default
+
+# Any other parameter from https://artifacthub.io/packages/helm/bitnami/mysql
+mysql:
+  enabled: true
+  # Required because db driver doesn't support mysql 8...
+  image:
+    tag: '5.7'
+  auth:
+    # Please change these...
+    rootPassword: ozIRdODs8Jvs3BzZywgK
+    password: ihcqsCcsX6

Review comment:
       Hello there, sorry for my delay here!
   
   We can't use `randAlphaNum` inside the chart because that would cause the value to be re-generated each time we deploy. However there's no problem to keep that value empty and implement a runtime warning to instruct users to provide a value.
   
   I'm not so sure that "people will NOT change these" is really true any more with Helm since it's just so easy to do... but for extra protection it makes sense to force it, I can do that.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org