You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Chesnay Schepler (Jira)" <ji...@apache.org> on 2021/06/09 10:22:00 UTC
[jira] [Assigned] (FLINK-19164) Release scripts break other
dependency versions unintentionally
[ https://issues.apache.org/jira/browse/FLINK-19164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chesnay Schepler reassigned FLINK-19164:
----------------------------------------
Assignee: Serhat Soydan
> Release scripts break other dependency versions unintentionally
> ---------------------------------------------------------------
>
> Key: FLINK-19164
> URL: https://issues.apache.org/jira/browse/FLINK-19164
> Project: Flink
> Issue Type: Bug
> Components: Deployment / Scripts, Release System
> Reporter: Serhat Soydan
> Assignee: Serhat Soydan
> Priority: Minor
> Labels: auto-unassigned, pull-request-available
> Fix For: 1.14.0
>
>
> All the scripts below has a line to change the old version to new version in pom files.
> [https://github.com/apache/flink/blob/master/tools/change-version.sh#L31]
> [https://github.com/apache/flink/blob/master/tools/releasing/create_release_branch.sh#L60]
> [https://github.com/apache/flink/blob/master/tools/releasing/update_branch_version.sh#L52]
>
> It works like find & replace so it is prone to unintentional errors. Any dependency with a version equals to "old version" might be automatically changed to "new version". See below to see how to produce a similar case.
>
> +How to re-produce the bug:+
> * Clone/Fork Flink repo and for example checkout version v*1.11.1*
> * Apply any changes you need
> * Run "create_release_branch.sh" script with OLD_VERSION=*1.11.1* NEW_VERSION={color:#de350b}*1.12.0*{color}
> ** In parent pom.xml, an auto find&replace of maven-dependency-analyzer version will be done automatically and *unintentionally* which will break the build.
>
> <dependency>
> <groupId>org.apache.maven.shared</groupId>
> <artifactId>maven-dependency-analyzer</artifactId>
> <version>*1.11.1*</version>
> </dependency>
>
> <dependency>
> <groupId>org.apache.maven.shared</groupId>
> <artifactId>maven-dependency-analyzer</artifactId>
> <version>{color:#de350b}*1.12.0*{color}</version>
> </dependency>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)