[GitHub] [spark] maropu commented on a change in pull request #24209: [SPARK-27255][SQL] Report error when illegal expressions are hosted by a plan operator.

[GitBox <gi...@apache.org>]

maropu commented on a change in pull request #24209: [SPARK-27255][SQL] Report error when illegal expressions are hosted by a plan operator.
URL: https://github.com/apache/spark/pull/24209#discussion_r270702791
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
 ##########
 @@ -376,6 +376,17 @@ trait CheckAnalysis extends PredicateHelper {
             throw new IllegalStateException(
               "Internal error: logical hint operator should have been removed during analysis")
 
+          case f @ Filter(condition, _) if PlanHelper.specialExpressionInUnsupportedOperator(f) =>
+            failAnalysis(
+              s"""
+                 |Aggregate/Window/Generate expressions are not valid in where clause of the query.
+                 |Expression in where clause: ${condition.sql}
+               """.stripMargin)
+
+          case other if PlanHelper.specialExpressionInUnsupportedOperator(other) =>
+            failAnalysis(s"The query operator  `${other.nodeName}` contains " +
 
 Review comment:
   nit: remove an unnecessary single space.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org