You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2018/06/19 21:22:33 UTC

commons-pool git commit: local var should not hide ivar.

Repository: commons-pool
Updated Branches:
  refs/heads/master dfef97be7 -> cbb41d7d9


local var should not hide ivar.

Project: http://git-wip-us.apache.org/repos/asf/commons-pool/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-pool/commit/cbb41d7d
Tree: http://git-wip-us.apache.org/repos/asf/commons-pool/tree/cbb41d7d
Diff: http://git-wip-us.apache.org/repos/asf/commons-pool/diff/cbb41d7d

Branch: refs/heads/master
Commit: cbb41d7d9fe6206085ae204cda0154ebef1f31da
Parents: dfef97b
Author: Gary Gregory <ga...@gmail.com>
Authored: Tue Jun 19 15:22:27 2018 -0600
Committer: Gary Gregory <ga...@gmail.com>
Committed: Tue Jun 19 15:22:27 2018 -0600

----------------------------------------------------------------------
 .../org/apache/commons/pool2/impl/BaseGenericObjectPool.java   | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-pool/blob/cbb41d7d/src/main/java/org/apache/commons/pool2/impl/BaseGenericObjectPool.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/pool2/impl/BaseGenericObjectPool.java b/src/main/java/org/apache/commons/pool2/impl/BaseGenericObjectPool.java
index aaaa7bc..5838a0d 100644
--- a/src/main/java/org/apache/commons/pool2/impl/BaseGenericObjectPool.java
+++ b/src/main/java/org/apache/commons/pool2/impl/BaseGenericObjectPool.java
@@ -1011,7 +1011,7 @@ public abstract class BaseGenericObjectPool<T> extends BaseObject {
      */
     private ObjectName jmxRegister(final BaseObjectPoolConfig<T> config,
             final String jmxNameBase, String jmxNamePrefix) {
-        ObjectName objectName = null;
+        ObjectName newObjectName = null;
         final MBeanServer mbs = ManagementFactory.getPlatformMBeanServer();
         int i = 1;
         boolean registered = false;
@@ -1030,7 +1030,7 @@ public abstract class BaseGenericObjectPool<T> extends BaseObject {
                     objName = new ObjectName(base + jmxNamePrefix + i);
                 }
                 mbs.registerMBean(this, objName);
-                objectName = objName;
+                newObjectName = objName;
                 registered = true;
             } catch (final MalformedObjectNameException e) {
                 if (BaseObjectPoolConfig.DEFAULT_JMX_NAME_PREFIX.equals(
@@ -1051,7 +1051,7 @@ public abstract class BaseGenericObjectPool<T> extends BaseObject {
                 registered = true;
             }
         }
-        return objectName;
+        return newObjectName;
     }
 
     /**