You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/06/19 05:33:31 UTC

[GitHub] [phoenix-queryserver] stoty commented on pull request #39: PHOENIX-5901 Fix licensing in preparation for first python release

stoty commented on pull request #39:
URL: https://github.com/apache/phoenix-queryserver/pull/39#issuecomment-646444127


   > > I've just noticed that this doesn't touch the LICENSE and NOTICE files in the python/phoenixdb directory.
   > 
   > I don't see any L&N files in python/phoenixdb. Are you talking about the LICENSE files in the .eggs?
   
   My mistake, I saw them locally on my system.
   
   There are two issues left:
   
   * We need to update the python script path for the java tests.
   (SecureQueryServerPhoenixDBIT SecureQueryServerPhoenixDBIT.java lines 342 and 367, and test_phoenixdb.sh line 63)
   
   * May want to consider removing README.md. Looks like github will show README.rst the same way if it can parse it. (you seemed to agree to do it, but maybe you only meant the directory flattening)  
   
   And a bonus one, for maybe another ticket: Why doesn't mvn install run the ITs ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org