You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "frankgh (via GitHub)" <gi...@apache.org> on 2023/06/14 19:03:26 UTC
[GitHub] [cassandra-sidecar] frankgh opened a new pull request, #50: CASSANDRASC-54 Add NOTICE.txt file
frankgh opened a new pull request, #50:
URL: https://github.com/apache/cassandra-sidecar/pull/50
The NOTICE.txt file is currently missing in the repository. This commit adds the file to comply with ASF's guidance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-sidecar] michaelsembwever commented on pull request #50: CASSANDRASC-54 Add NOTICE.txt file
Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on PR #50:
URL: https://github.com/apache/cassandra-sidecar/pull/50#issuecomment-1605454925
out-of-scope, would it be smart to add the rat plugin as part of the build (in a separate ticket/pr) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-sidecar] frankgh closed pull request #50: CASSANDRASC-54 Add NOTICE.txt file
Posted by "frankgh (via GitHub)" <gi...@apache.org>.
frankgh closed pull request #50: CASSANDRASC-54 Add NOTICE.txt file
URL: https://github.com/apache/cassandra-sidecar/pull/50
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-sidecar] frankgh commented on pull request #50: CASSANDRASC-54 Add NOTICE.txt file
Posted by "frankgh (via GitHub)" <gi...@apache.org>.
frankgh commented on PR #50:
URL: https://github.com/apache/cassandra-sidecar/pull/50#issuecomment-1592007667
> looks good, but while you're at it i think you should fix (remove) this: https://github.com/apache/cassandra-sidecar/blob/trunk/LICENSE.txt#L205C1-L209 (as there is no lib/ folder)
>
> are you using the rat plugin to check all files have license headers ? and checked that all dependencies are apache license compatible?
We are not using the rat plugin, I will take a look at that. Should we do that as a follow up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-sidecar] frankgh commented on pull request #50: CASSANDRASC-54 Add NOTICE.txt file
Posted by "frankgh (via GitHub)" <gi...@apache.org>.
frankgh commented on PR #50:
URL: https://github.com/apache/cassandra-sidecar/pull/50#issuecomment-1604753352
> are you using the rat plugin to check all files have license headers ? and checked that all dependencies are apache license compatible?
I ran the rat tool manually. All the source files have license headers. I also checked that all dependencies are ASL compatible. This was a manual process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-sidecar] frankgh commented on pull request #50: CASSANDRASC-54 Add NOTICE.txt file
Posted by "frankgh (via GitHub)" <gi...@apache.org>.
frankgh commented on PR #50:
URL: https://github.com/apache/cassandra-sidecar/pull/50#issuecomment-1605676971
Closed via https://github.com/apache/cassandra-sidecar/commit/2cc2eb5844e1f7ec54b2934589c2f4a6a3d226bc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-sidecar] frankgh commented on pull request #50: CASSANDRASC-54 Add NOTICE.txt file
Posted by "frankgh (via GitHub)" <gi...@apache.org>.
frankgh commented on PR #50:
URL: https://github.com/apache/cassandra-sidecar/pull/50#issuecomment-1605676909
> out-of-scope, would it be smart to add the rat plugin as part of the build (in a separate ticket/pr) ?
Yes, I will go ahead and create a new ticket for that effort.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-sidecar] michaelsembwever commented on pull request #50: CASSANDRASC-54 Add NOTICE.txt file
Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on PR #50:
URL: https://github.com/apache/cassandra-sidecar/pull/50#issuecomment-1591991833
looks good, but while you're at it i think you should fix (remove) this: https://github.com/apache/cassandra-sidecar/blob/trunk/LICENSE.txt#L205C1-L209 (as there is no lib/ folder)
are you using the rat plugin to check all files have license headers ?
and checked that all dependencies are apache license compatible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org