You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "efegokdemir (via GitHub)" <gi...@apache.org> on 2026/09/23 14:54:59 UTC

[PR] Use UTF-8 for text metadata [maven-shared-jar]

efegokdemir opened a new pull request, #176:
URL: https://github.com/apache/maven-shared-jar/pull/176

   ## Summary
   
   Fixes #175 by making TextFileExposer use an explicit UTF-8 charset when reading text metadata. Platform-default decoding could corrupt non-ASCII version values on systems with a different default charset.
   
   ## Changes
   
   - Decode text metadata with `StandardCharsets.UTF_8`.
   - Add a regression test covering a non-ASCII version value in a JAR entry.
   
   ## Testing
   
   - `JAVA_HOME=/opt/homebrew/opt/openjdk@21 mvn -Dtest=TextFileExposerTest test` — PASS (1 test).
   - `JAVA_HOME=/opt/homebrew/opt/openjdk@21 mvn -Prun-its verify` — PASS (90 tests; profile is not defined in this project, so Maven reported that it was not activated).
   - `git diff --check` — PASS.
   
   ## Notes
   
   The change is intentionally limited to deterministic decoding for the existing generic text-file exposer; it does not change the metadata detection or selection logic. AI assistance was used during implementation, and the complete diff and test results were reviewed before submission.
   
   No overlapping open PR was found during the final duplicate check.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Use UTF-8 for text metadata [maven-shared-jar]

Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on PR #176:
URL: https://github.com/apache/maven-shared-jar/pull/176#issuecomment-5855227023

   simple fixes won't work here


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Use UTF-8 for text metadata [maven-shared-jar]

Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo closed pull request #176: Use UTF-8 for text metadata
URL: https://github.com/apache/maven-shared-jar/pull/176


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org