You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/15 10:12:30 UTC

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #12421: ARROW-5248: [Python] support zoneinfo / dateutil timezones

jorisvandenbossche commented on a change in pull request #12421:
URL: https://github.com/apache/arrow/pull/12421#discussion_r806664806



##########
File path: cpp/src/arrow/python/datetime.cc
##########
@@ -470,6 +474,28 @@ Result<std::string> TzinfoToString(PyObject* tzinfo) {
     return result;
   }
 
+  // try to look up key attribute

Review comment:
       Maybe add a comment here that this check is explicitly for zoneinfo objects, and below the same for dateutil




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org