svn commit: r1685394 - in /jmeter/trunk: src/core/org/apache/jmeter/save/converters/SampleResultConverter.java xdocs/changes.xml xdocs/usermanual/listeners.xml

[se...@apache.org]

Author: sebb
Date: Sun Jun 14 12:01:56 2015
New Revision: 1685394

URL: http://svn.apache.org/r1685394
Log:
 SampleResultConverter should note that it cannot record non-TEXT data
Bugzilla Id: 58033

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/save/converters/SampleResultConverter.java
    jmeter/trunk/xdocs/changes.xml
    jmeter/trunk/xdocs/usermanual/listeners.xml

Modified: jmeter/trunk/src/core/org/apache/jmeter/save/converters/SampleResultConverter.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/save/converters/SampleResultConverter.java?rev=1685394&r1=1685393&r2=1685394&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/save/converters/SampleResultConverter.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/save/converters/SampleResultConverter.java Sun Jun 14 12:01:56 2015
@@ -171,10 +171,12 @@ public class SampleResultConverter exten
             try {
                 if (SampleResult.TEXT.equals(res.getDataType())){
                     writer.setValue(new String(res.getResponseData(), res.getDataEncodingWithDefault()));
+                } else {
+                    writer.setValue("Non-TEXT response data, cannot record: (" + res.getDataType() + ")");                    
                 }
                 // Otherwise don't save anything - no point
             } catch (UnsupportedEncodingException e) {
-                writer.setValue("Unsupported encoding in response data, can't record.");
+                writer.setValue("Unsupported encoding in response data, cannot record: " + e);
             }
             writer.endNode();
         }

Modified: jmeter/trunk/xdocs/changes.xml
URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1685394&r1=1685393&r2=1685394&view=diff
==============================================================================
--- jmeter/trunk/xdocs/changes.xml (original)
+++ jmeter/trunk/xdocs/changes.xml Sun Jun 14 12:01:56 2015
@@ -142,6 +142,7 @@ Summary
 
 <h3>Listeners</h3>
 <ul>
+<li><bug>58033</bug> SampleResultConverter should note that it cannot record non-TEXT data</li>
 </ul>
 
 <h3>Timers, Assertions, Config, Pre- &amp; Post-Processors</h3>

Modified: jmeter/trunk/xdocs/usermanual/listeners.xml
URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/usermanual/listeners.xml?rev=1685394&r1=1685393&r2=1685394&view=diff
==============================================================================
--- jmeter/trunk/xdocs/usermanual/listeners.xml (original)
+++ jmeter/trunk/xdocs/usermanual/listeners.xml Sun Jun 14 12:01:56 2015
@@ -456,6 +456,7 @@ See <a href="#sample_variables">Sample v
 As shown above, the response data can be saved in the XML log file if required.
 However, this can make the file rather large, and the text has to be encoded so
 that it is still valid XML. Also, images cannot be included.
+Only sample responses with the type TEXT can be saved.
 <br/>
 Another solution is to use the Post-Processor <complink name="Save_Responses_to_a_file">Save Responses to a file</complink>.
 This generates a new file for each sample, and saves the file name with the sample.