You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/06/02 02:10:20 UTC
[GitHub] [echarts] h7ml opened a new pull request, #17147: fix: eslint
h7ml opened a new pull request, #17147:
URL: https://github.com/apache/echarts/pull/17147
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [x] new feature
- [ ] others
### What does this PR do?
eslint normalization to remove unnecessary imports
### Fixed issues
<!--
- #xxxx: ...
-->
## Details
### Before: What was the problem?
<!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
### After: How is it fixed in this PR?
<!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
## Misc
<!-- ADD RELATED ISSUE ID WHEN APPLICABLE -->
- [ ] The API has been changed (apache/echarts-doc#xxx).
- [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
### Related test cases or examples to use the new APIs
``pnpm lint``
## Others
### Merging options
- [ ] Please squash the commits into a single one when merging.
### Other information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] h7ml commented on pull request #17147: fix: eslint
Posted by GitBox <gi...@apache.org>.
h7ml commented on PR #17147:
URL: https://github.com/apache/echarts/pull/17147#issuecomment-1147194731
Consider using `` tslint+prettier+husky+lint-staged`` code formatting specification guarantees
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #17147: fix: eslint
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on PR #17147:
URL: https://github.com/apache/echarts/pull/17147#issuecomment-1144342473
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Ovilia commented on pull request #17147: fix: eslint
Posted by GitBox <gi...@apache.org>.
Ovilia commented on PR #17147:
URL: https://github.com/apache/echarts/pull/17147#issuecomment-1147228926
Thanks for the suggestion. I think the main problem we need to decide is what to do with the old stylings. Please continue the discusstion in [the mailing list](https://lists.apache.org/thread/kt4s7tjxk512qh4ysp1dw1cov4r7qqkj). I would like to close this PR if you are OK with that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Ovilia commented on pull request #17147: fix: eslint
Posted by GitBox <gi...@apache.org>.
Ovilia commented on PR #17147:
URL: https://github.com/apache/echarts/pull/17147#issuecomment-1147122157
If we decide to do auto formatting for the whole project, prettier would not be enough but it should be used along with eslint.
I think we should first start a discussion on our mailing list that whether we should start using auto formatting tools and then formats all current code once. This PR seems to only fix the formatting of a small number of files and I think the format rules are not correct (e.g., we use 4 spaces rather than 2 spaces). So I would suggest closing this PR for now but we do appreciate the help!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] h7ml commented on pull request #17147: fix: eslint
Posted by GitBox <gi...@apache.org>.
h7ml commented on PR #17147:
URL: https://github.com/apache/echarts/pull/17147#issuecomment-1147071507
> Thanks for the changing! Did you use some auto formatting tools (like prettier) or manually changed this?
Yes, I do use the auto format tool, I use the prettier that comes with vscode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] h7ml commented on pull request #17147: fix: eslint
Posted by GitBox <gi...@apache.org>.
h7ml commented on PR #17147:
URL: https://github.com/apache/echarts/pull/17147#issuecomment-1147191565
In [the action lint] (https://github.com/apache/echarts/actions/runs/2420710373),
There is always an issue with not being able to pass Lint, maybe you should pay attention to this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Ovilia commented on pull request #17147: fix: eslint
Posted by GitBox <gi...@apache.org>.
Ovilia commented on PR #17147:
URL: https://github.com/apache/echarts/pull/17147#issuecomment-1146996649
Thanks for the changing! Did you use some auto formatting tools (like prettier) or manually changed this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] h7ml commented on pull request #17147: fix: eslint
Posted by GitBox <gi...@apache.org>.
h7ml commented on PR #17147:
URL: https://github.com/apache/echarts/pull/17147#issuecomment-1144350397
## Deleted the code that was introduced but not used in the code as follows
1. [BoxplotSeriesModel](https://github.com/apache/echarts/pull/17147/files#diff-ebc0d26bc0f700b8374adf54cfca30189cd780a4e3b48acaa7eb7220ebc842e2L22)
2. [SunburstSeriesNodeItemOption](https://github.com/apache/echarts/pull/17147/files#diff-2e4a828a366e05a52c1a1b52b9eae9412190e9f343b313465aeff82174564a3aR24)
3. [TreemapSeriesOption](https://github.com/apache/echarts/pull/17147/files#diff-f3d866579b39927bb1e154fd3c6b5a5146aa36eeb169b8c4697a6ecee41178d7L22)
4. [GetPieceValueType](https://github.com/apache/echarts/pull/17147/files#diff-52d0c614050f6d45fac915e98b35e86031de8ad0e1f8eda443d154e99527567eL47)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] h7ml closed pull request #17147: fix: eslint
Posted by GitBox <gi...@apache.org>.
h7ml closed pull request #17147: fix: eslint
URL: https://github.com/apache/echarts/pull/17147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org