You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/04/23 18:13:29 UTC

[kudu-CR](branch-1.12.x) [test] fix TestCorruptKerberosCC scenario 

Hello Kudu Jenkins, Grant Henke, Bankim Bhavsar,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/15789

to review the following change.


Change subject: [test] fix TestCorruptKerberosCC scenario
......................................................................

[test] fix TestCorruptKerberosCC scenario

On macOS, the SecurityITest.TestCorruptKerberosCC scenario was failing
with errors like below:

  src/kudu/integration-tests/security-itest.cc:430: Failure
  Value of: s.ok()
    Actual: true
  Expected: false
  Google Test trace:
  src/kudu/integration-tests/security-itest.cc:419: Truncating ccache at
    'security-itest.0.SecurityITest.TestCorruptKerberosCC/krb5kdc/krb5cc' to 500

It seems Kerberos cache truncated to 500 bytes is big enough to
successfully extract necessary data on macOS.

This patch decreases the size of the corrupted client cache to 266
bytes, so now the scenario passes on macOS as well.  In addition,
the truncation size is now selected randomly.

Change-Id: I765e9f1f6cd208f86bc321e962588982f9e01447
Reviewed-on: http://gerrit.cloudera.org:8080/15786
Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
(cherry picked from commit b0d5852591b2452cd12b46ab4070752014b2e954)
---
M src/kudu/integration-tests/security-itest.cc
1 file changed, 10 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/15789/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15789
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I765e9f1f6cd208f86bc321e962588982f9e01447
Gerrit-Change-Number: 15789
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.12.x) [test] fix TestCorruptKerberosCC scenario

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15789 )

Change subject: [test] fix TestCorruptKerberosCC scenario
......................................................................

[test] fix TestCorruptKerberosCC scenario

On macOS, the SecurityITest.TestCorruptKerberosCC scenario was failing
with errors like below:

  src/kudu/integration-tests/security-itest.cc:430: Failure
  Value of: s.ok()
    Actual: true
  Expected: false
  Google Test trace:
  src/kudu/integration-tests/security-itest.cc:419: Truncating ccache at
    'security-itest.0.SecurityITest.TestCorruptKerberosCC/krb5kdc/krb5cc' to 500

It seems Kerberos cache truncated to 500 bytes is big enough to
successfully extract necessary data on macOS.

This patch decreases the size of the corrupted client cache to 266
bytes, so now the scenario passes on macOS as well.  In addition,
the truncation size is now selected randomly.

Change-Id: I765e9f1f6cd208f86bc321e962588982f9e01447
Reviewed-on: http://gerrit.cloudera.org:8080/15786
Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
(cherry picked from commit b0d5852591b2452cd12b46ab4070752014b2e954)
Reviewed-on: http://gerrit.cloudera.org:8080/15789
Reviewed-by: Hao Hao <ha...@cloudera.com>
---
M src/kudu/integration-tests/security-itest.cc
1 file changed, 10 insertions(+), 7 deletions(-)

Approvals:
  Hao Hao: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15789
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I765e9f1f6cd208f86bc321e962588982f9e01447
Gerrit-Change-Number: 15789
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.12.x) [test] fix TestCorruptKerberosCC scenario

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15789 )

Change subject: [test] fix TestCorruptKerberosCC scenario
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15789
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I765e9f1f6cd208f86bc321e962588982f9e01447
Gerrit-Change-Number: 15789
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 23 Apr 2020 18:22:21 +0000
Gerrit-HasComments: No